We should use the contextual return option added in bug 31699 to ensure a patron is returned to the biblio details page they were on when trying to add a comment to said biblio and getting prompted to login.
Created attachment 143376 [details] [review] Bug 32125: Impliment modal context return on opac-detail. This patch utilises the generic return option introduced in the previous patch to prevent lose of context when clicking to login to add a comment to a biblio. Test plan 1/ Test that prior to this patch, upon clicking 'Log in to your account to post a comment' you are redirected to opac-user.pl and thus loose your context. 2/ Apply the patch 3/ Confirm that a login using the 'Log in to your account to post a comment' link now redirect immediatly back the correct record and thus maintains context. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 143377 [details] [review] Bug 32125: Select correct tab on return Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This simply splits the work from bug 31699 to better document it for the release notes.. carrying over SO and QA stamps
Created attachment 143466 [details] [review] Bug 32125: Impliment modal context return on opac-detail. This patch utilises the generic return option introduced in the previous patch to prevent lose of context when clicking to login to add a comment to a biblio. Test plan 1/ Test that prior to this patch, upon clicking 'Log in to your account to post a comment' you are redirected to opac-user.pl and thus loose your context. 2/ Apply the patch 3/ Confirm that a login using the 'Log in to your account to post a comment' link now redirect immediatly back the correct record and thus maintains context. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 143467 [details] [review] Bug 32125: Select correct tab on return Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.