This is according to our capitalization rules.
https://www.dictionary.com/browse/e- It doesn't have e-resource, but it has other examples of e- and in all those cases the second word is not capitalized.
Created attachment 143510 [details] [review] Bug 32147: Capitalization: E-Resource management When e- is used as prefix, the second word should not be capitalized. To test: * Best to check the code... but: * All E-Resource should now read E-resource, as on: * Koha start page * Breadcrumbs in the ERM module * Descriptions of AV categories... I chose to update the sysprefs.sql and the DB update as well as this hasn't been released yet.
Created attachment 143511 [details] [review] Bug 32147: Capitalization: E-Resource management When e- is used as prefix, the second word should not be capitalized. And when e-resource-management is used as part of a sentence, the e shouldn't be either. See: e-mail, e-commerce. etc. To test: * Best to check the code... but: * All E-Resource should now read e-resource or E-resource, as on: * Koha start page * Breadcrumbs in the ERM module * Descriptions of AV categories... I chose to update the sysprefs.sql and the DB update as well as this hasn't been released yet.
Must admit.. I don't know what the standard terms are here really.. I feel like it's an abbreviation and should be 'ERM' or 'Electronic resource management'.. 'E-resource management' feels strange to look at.. 'e-resource management' not so strange, but doesn't capitalise well for sentence case.
https://en.wikipedia.org/wiki/Electronic_resource_management
I tried changing the button on the start page to Electronic resource management, but it adds a line break. Changing this might require a bit more than a string change then. I like ERM and Eletronic resource management, but I really want to have a solution before we reach string freeze tomorrow.
Disclaimer: as you all know, English is not my first language, so take my comments accordingly. Personally, I like the long form better; Electronic resource management. Also, I've always seen the small e when used for "electronic", like e-Book or eBook, except where the word has entered regular vocabulary, like Email.
There is a space missing in the description of the ERM_AGREEMENT_LICENSE_STATUS authorized value category. Statuses of the licenses' agreements(e-resource management module) Should be Statuses of the licenses' agreements (e-resource management module)
Created attachment 143522 [details] [review] Bug 32147: (follow-up) Fix missing space One of the AV category descriptions was missing a space before the (e-resource management).
Main page - OK More menu - OK ERM module - I'm missing the yarn thing, so I didn't test that, sorry... System preferences - OK Authorized values - OK
(In reply to Martin Renvoize from comment #4) > Must admit.. I don't know what the standard terms are here really.. > > I feel like it's an abbreviation and should be 'ERM' or 'Electronic resource > management'.. 'E-resource management' feels strange to look at.. 'e-resource > management' not so strange, but doesn't capitalise well for sentence case. There's actually a reason behind this! Electronic Resource Management is really the proper term but, when we used that initially, the string was so long that it looked very odd on the dropdown menu and the Koha Home screen. So we shortened!
I completely understand about avoiding the longer form, but the capital R is what triggers me as it stands out in the interface now going against our rules. For me this would work like e-mail, e-commerce, e-resource... e-journal. It's not a name, it's not an abbreviation and the dictionaries suggest the lower r. We refer to that dictionary on https://wiki.koha-community.org/wiki/Terminology.
(In reply to Katrin Fischer from comment #12) > I completely understand about avoiding the longer form, but the capital R is > what triggers me as it stands out in the interface now going against our > rules. > > For me this would work like e-mail, e-commerce, e-resource... e-journal. > > It's not a name, it's not an abbreviation and the dictionaries suggest the > lower r. > > We refer to that dictionary on > https://wiki.koha-community.org/wiki/Terminology. Fine, let's go with your proposal then!
Created attachment 143695 [details] [review] Bug 32147: Capitalization: E-Resource management When e- is used as prefix, the second word should not be capitalized. And when e-resource-management is used as part of a sentence, the e shouldn't be either. See: e-mail, e-commerce. etc. To test: * Best to check the code... but: * All E-Resource should now read e-resource or E-resource, as on: * Koha start page * Breadcrumbs in the ERM module * Descriptions of AV categories... I chose to update the sysprefs.sql and the DB update as well as this hasn't been released yet. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 143696 [details] [review] Bug 32147: (follow-up) Fix missing space One of the AV category descriptions was missing a space before the (e-resource management). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 143937 [details] [review] Bug 32147: Capitalization: E-Resource management When e- is used as prefix, the second word should not be capitalized. And when e-resource-management is used as part of a sentence, the e shouldn't be either. See: e-mail, e-commerce. etc. To test: * Best to check the code... but: * All E-Resource should now read e-resource or E-resource, as on: * Koha start page * Breadcrumbs in the ERM module * Descriptions of AV categories... I chose to update the sysprefs.sql and the DB update as well as this hasn't been released yet. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Bug 32147: (follow-up) Fix missing space One of the AV category descriptions was missing a space before the (e-resource management). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.11. Nice work everyone, thanks!