Bug 32165 - Add page-section to some catalog pages
Summary: Add page-section to some catalog pages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-11-10 11:01 UTC by Martin Renvoize
Modified: 2023-06-08 22:28 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32165: Add page-section to labeledMARCdetail (1.24 KB, patch)
2022-11-10 11:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32165: Add page-section to ISBDdetail (2.46 KB, patch)
2022-11-10 11:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32165: Add page-section to issuehistory (1.22 KB, patch)
2022-11-10 11:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32165: Add page-section to labeledMARCdetail (1.30 KB, patch)
2022-11-10 15:34 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32165: Add page-section to ISBDdetail (2.49 KB, patch)
2022-11-10 15:34 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32165: Add page-section to issuehistory (1.27 KB, patch)
2022-11-10 15:34 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32165: (QA follow-up) Fix tabs in ISBD details (1.36 KB, patch)
2022-11-10 15:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-11-10 11:01:39 UTC
This bug aims to catch any low hanging fruit on the pages linked from the left side menu when viewing a catalog detail page.
Comment 1 Martin Renvoize 2022-11-10 11:04:01 UTC
Created attachment 143638 [details] [review]
Bug 32165: Add page-section to labeledMARCdetail

Test plan
1) Confirm that page-sections now appear as expected on the labeled marc
   view.
Comment 2 Martin Renvoize 2022-11-10 11:04:06 UTC
Created attachment 143639 [details] [review]
Bug 32165: Add page-section to ISBDdetail

We fix some whitespace and move the toolbar above the H1 too.

Test plan
1) Confirm the headings and page-sections now look correct on the ISBD
   details view
Comment 3 Martin Renvoize 2022-11-10 11:04:10 UTC
Created attachment 143640 [details] [review]
Bug 32165: Add page-section to issuehistory

Test plan
1) Confirm the issue history view now uses page-section appropriately
Comment 4 Martin Renvoize 2022-11-10 11:04:57 UTC
Quick self signoff to hit the QA queue.. I deliberately missed the items detail page as that's already got a bug associated to it and is non-trivial to fix.
Comment 5 Katrin Fischer 2022-11-10 15:34:05 UTC
Created attachment 143674 [details] [review]
Bug 32165: Add page-section to labeledMARCdetail

Test plan
1) Confirm that page-sections now appear as expected on the labeled marc
   view.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2022-11-10 15:34:10 UTC
Created attachment 143675 [details] [review]
Bug 32165: Add page-section to ISBDdetail

We fix some whitespace and move the toolbar above the H1 too.

Test plan
1) Confirm the headings and page-sections now look correct on the ISBD
   details view

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-11-10 15:34:15 UTC
Created attachment 143676 [details] [review]
Bug 32165: Add page-section to issuehistory

Test plan
1) Confirm the issue history view now uses page-section appropriately

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2022-11-10 15:34:19 UTC
Created attachment 143677 [details] [review]
Bug 32165: (QA follow-up) Fix tabs in ISBD details

The QA test tools complained about tabs in 2 lines, this is fixed here.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2022-11-10 17:51:56 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!