Bug 32188 - Only show template controls above item form if templates have been defined
Summary: Only show template controls above item form if templates have been defined
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords: rel_22_11_candidate
Depends on: 24606
Blocks:
  Show dependency tree / graph
 
Reported: 2022-11-13 22:34 UTC by Katrin Fischer
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 32188: Only show template controls above item form if templates have been defined (7.55 KB, patch)
2022-11-14 16:09 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 32188: Only show template controls above item form if templates have been defined (7.61 KB, patch)
2022-11-14 16:40 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-13 22:34:03 UTC 
The new item templates above the item edit form should only show, when at least one template has been defined.
Comment 1 Kyle M Hall (khall) 2022-11-14 16:09:46 UTC 
Created attachment 143843 [details] [review]
Bug 32188: Only show template controls above item form if templates have been defined

The new item templates above the item edit form should only show, when at least one template has been defined.

Test Plan:
1) Browse to the item editor
2) Delete all templates
3) Note the template toolbar is displayed
4) Apply this patch
5) Reload the page, note the toolbar is not displayed
6) Create a new template, note the toolbar is now displayed
7) Delete that template, note the toolbar is no longer displayed
Comment 2 Katrin Fischer 2022-11-14 16:30:33 UTC 
Looking here...
Comment 3 Katrin Fischer 2022-11-14 16:40:33 UTC 
Created attachment 143846 [details] [review]
Bug 32188: Only show template controls above item form if templates have been defined

The new item templates above the item edit form should only show, when at least one template has been defined.

Test Plan:
1) Browse to the item editor
2) Delete all templates
3) Note the template toolbar is displayed
4) Apply this patch
5) Reload the page, note the toolbar is not displayed
6) Create a new template, note the toolbar is now displayed
7) Delete that template, note the toolbar is no longer displayed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-11-14 16:40:51 UTC 
Setting straight to PQA.
Comment 5 Tomás Cohen Arazi (tcohen) 2022-11-14 18:09:21 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!