Bug 32199 - Add page-section to various patron pages
Summary: Add page-section to various patron pages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-11-14 18:09 UTC by Owen Leonard
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32199: Add page-section to various patron pages (32.57 KB, patch)
2022-11-14 18:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32199: Add page-section to various patron pages (32.68 KB, patch)
2022-11-14 19:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32199: (follow-up) Add page-section to circulation history (1.17 KB, patch)
2022-11-14 19:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32199: (follow-up) Add page-section to list of validated discharges (2.66 KB, patch)
2022-11-14 19:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32199: Add page-section to various patron pages (32.61 KB, patch)
2022-11-14 19:55 UTC, David Nind
Details | Diff | Splinter Review
Bug 32199: Add page-section to various patron pages (32.67 KB, patch)
2022-11-14 20:04 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32199: (follow-up) Add page-section to circulation history (1.17 KB, patch)
2022-11-14 20:04 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32199: (follow-up) Add page-section to list of validated discharges (2.66 KB, patch)
2022-11-14 20:04 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32199: Add page-section to various patron pages (32.72 KB, patch)
2022-11-14 20:41 UTC, David Nind
Details | Diff | Splinter Review
Bug 32199: (follow-up) Add page-section to circulation history (1.22 KB, patch)
2022-11-14 20:41 UTC, David Nind
Details | Diff | Splinter Review
Bug 32199: (follow-up) Add page-section to list of validated discharges (2.71 KB, patch)
2022-11-14 20:41 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-14 18:09:19 UTC
Several patron-related pages need the page-section container:

- includes/ill-list-table.inc
- members/discharges.tt
- members/files.tt
- members/holdshistory.tt
- members/notices.tt
- members/purchase-suggestions.tt
- members/routing-lists.tt
- members/statistics.tt
Comment 1 Owen Leonard 2022-11-14 18:24:04 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2022-11-14 19:21:16 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2022-11-14 19:21:20 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2022-11-14 19:21:25 UTC Comment hidden (obsolete)
Comment 5 David Nind 2022-11-14 19:55:50 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2022-11-14 20:04:15 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2022-11-14 20:04:20 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2022-11-14 20:04:26 UTC Comment hidden (obsolete)
Comment 9 David Nind 2022-11-14 20:41:50 UTC
Created attachment 143870 [details] [review]
Bug 32199: Add page-section to various patron pages

This patch adds a .page-section div to various patron-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages to confirm that
the primary page content is wrapped in a container with a white
background:

- Patrons ->
    Patron details ->
      - Files
      - Holds history
      - ILL request history
      - Notices
      - Purchase suggestions
      - Routing lists
      - Statistics
- Staff interface home page ->
    Discharge requests pending

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2022-11-14 20:41:54 UTC
Created attachment 143871 [details] [review]
Bug 32199: (follow-up) Add page-section to circulation history

Note: There is a trick here. If OnsiteCheckouts are active,
the circulation history will be tabbed and not use page-section.
If the pref is off, you'll see the page-section with this patch.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: David Nind <david@davidnind.com>
Comment 11 David Nind 2022-11-14 20:41:59 UTC
Created attachment 143872 [details] [review]
Bug 32199: (follow-up) Add page-section to list of validated discharges

This requires that a discharge is added to the patron account first.
Then you'll see that the 'Aready validated discharges' appear within
the white page section.

Signed-off-by: David Nind <david@davidnind.com>
Comment 12 Tomás Cohen Arazi 2022-11-16 12:40:42 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!