Several patron-related pages need the page-section container: - includes/ill-list-table.inc - members/discharges.tt - members/files.tt - members/holdshistory.tt - members/notices.tt - members/purchase-suggestions.tt - members/routing-lists.tt - members/statistics.tt
Created attachment 143856 [details] [review] Bug 32199: Add page-section to various patron pages This patch adds a .page-section div to various patron-related pages in order to provide a consistent page structure. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Patrons -> Patron details -> - Files - Holds history - ILL request history - Notices - Purchase suggestions - Routing lists - Statistics - Staff interface home page -> Discharge requests pending
Created attachment 143861 [details] [review] Bug 32199: Add page-section to various patron pages This patch adds a .page-section div to various patron-related pages in order to provide a consistent page structure. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Patrons -> Patron details -> - Files - Holds history - ILL request history - Notices - Purchase suggestions - Routing lists - Statistics - Staff interface home page -> Discharge requests pending Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 143862 [details] [review] Bug 32199: (follow-up) Add page-section to circulation history Note: There is a trick here. If OnsiteCheckouts are active, the circulation history will be tabbed and not use page-section. If the pref is off, you'll see the page-section with this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 143863 [details] [review] Bug 32199: (follow-up) Add page-section to list of validated discharges This requires that a discharge is added to the patron account first. Then you'll see that the 'Aready validated discharges' appear within the white page section.
Created attachment 143866 [details] [review] Bug 32199: Add page-section to various patron pages This patch adds a .page-section div to various patron-related pages in order to provide a consistent page structure. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Patrons -> Patron details -> - Files - Holds history - ILL request history - Notices - Purchase suggestions - Routing lists - Statistics - Staff interface home page -> Discharge requests pending Signed-off-by: David Nind <david@davidnind.com>
Created attachment 143867 [details] [review] Bug 32199: Add page-section to various patron pages This patch adds a .page-section div to various patron-related pages in order to provide a consistent page structure. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Patrons -> Patron details -> - Files - Holds history - ILL request history - Notices - Purchase suggestions - Routing lists - Statistics - Staff interface home page -> Discharge requests pending Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 143868 [details] [review] Bug 32199: (follow-up) Add page-section to circulation history Note: There is a trick here. If OnsiteCheckouts are active, the circulation history will be tabbed and not use page-section. If the pref is off, you'll see the page-section with this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 143869 [details] [review] Bug 32199: (follow-up) Add page-section to list of validated discharges This requires that a discharge is added to the patron account first. Then you'll see that the 'Aready validated discharges' appear within the white page section.
Created attachment 143870 [details] [review] Bug 32199: Add page-section to various patron pages This patch adds a .page-section div to various patron-related pages in order to provide a consistent page structure. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Patrons -> Patron details -> - Files - Holds history - ILL request history - Notices - Purchase suggestions - Routing lists - Statistics - Staff interface home page -> Discharge requests pending Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 143871 [details] [review] Bug 32199: (follow-up) Add page-section to circulation history Note: There is a trick here. If OnsiteCheckouts are active, the circulation history will be tabbed and not use page-section. If the pref is off, you'll see the page-section with this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 143872 [details] [review] Bug 32199: (follow-up) Add page-section to list of validated discharges This requires that a discharge is added to the patron account first. Then you'll see that the 'Aready validated discharges' appear within the white page section. Signed-off-by: David Nind <david@davidnind.com>
Pushed to master for 22.11. Nice work everyone, thanks!