Bug 32207 - Add page-section to some circulation pages
Summary: Add page-section to some circulation pages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-11-15 11:46 UTC by Owen Leonard
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32207: Add page-section to some circulation pages (21.57 KB, patch)
2022-11-15 11:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32207: Add page-section to some circulation pages (21.62 KB, patch)
2022-11-15 14:21 UTC, David Nind
Details | Diff | Splinter Review
Bug 32207: Add page-section to some circulation pages (21.67 KB, patch)
2022-11-15 14:57 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-15 11:46:38 UTC
Several circulation-related pages need the page-section container:

- bookcount.tt
- branchoverdues.tt
- on-site_checkouts.tt
- overdue.tt
- transfers_to_send.tt
- transferstoreceive.tt
Comment 1 Owen Leonard 2022-11-15 11:57:18 UTC
Created attachment 143897 [details] [review]
Bug 32207: Add page-section to some circulation pages

This patch adds a .page-section div to various circ-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages in Circulation to
confirm that the primary page content is wrapped in a container with a
white background:

- Overdues
- Overdues with fines
- Transfers to receive: Your system should have items which have been
  transfered from at least two other libraries.
- Transfers to send: Your system must have one or more items in the
  branchtransfers table with the datesent value = null.
- On-site checkouts
- Catalog -> Bibliographic record -> Items -> View item's checkout
  history
Comment 2 David Nind 2022-11-15 14:21:49 UTC
Created attachment 143906 [details] [review]
Bug 32207: Add page-section to some circulation pages

This patch adds a .page-section div to various circ-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages in Circulation to
confirm that the primary page content is wrapped in a container with a
white background:

- Overdues
- Overdues with fines
- Transfers to receive: Your system should have items which have been
  transfered from at least two other libraries.
- Transfers to send: Your system must have one or more items in the
  branchtransfers table with the datesent value = null.
- On-site checkouts
- Catalog -> Bibliographic record -> Items -> View item's checkout
  history

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-15 14:57:47 UTC
Created attachment 143908 [details] [review]
Bug 32207: Add page-section to some circulation pages

This patch adds a .page-section div to various circ-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages in Circulation to
confirm that the primary page content is wrapped in a container with a
white background:

- Overdues
- Overdues with fines
- Transfers to receive: Your system should have items which have been
  transfered from at least two other libraries.
- Transfers to send: Your system must have one or more items in the
  branchtransfers table with the datesent value = null.
- On-site checkouts
- Catalog -> Bibliographic record -> Items -> View item's checkout
  history

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-16 12:40:48 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!