Bug 32215 - 'You Searched for' for patron restrictions is not used
Summary: 'You Searched for' for patron restrictions is not used
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
Depends on: 23681
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-15 21:49 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32215: Remove unused "Your searched for" lines from patron restrictions admin page (1.17 KB, patch)
2023-02-20 23:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32215: Remove unused "Your searched for" lines from patron restrictions admin page (1.17 KB, patch)
2023-02-20 23:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32215: Remove unused "Your searched for" lines from patron restrictions admin page (1.26 KB, patch)
2023-02-21 09:45 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 32215: Remove unused "Your searched for" lines from patron restrictions admin page (1.31 KB, patch)
2023-02-23 09:39 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-15 21:49:59 UTC
Found while translating, so still needs to be located in the GUI:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:163
%s You Searched for %s
Comment 1 Katrin Fischer 2023-02-05 00:44:59 UTC
Hm, it's easy to fix, but I am failing to see it in the GUI. This should appear on administration > restrictions.
Comment 2 Owen Leonard 2023-02-07 13:36:49 UTC
I think this is some copy-paste from another template that isn't relevant here.
Comment 3 Katrin Fischer 2023-02-20 23:10:23 UTC
Created attachment 146985 [details] [review]
Bug 32215: Remove unused "Your searched for" lines from patron restrictions admin page

To test:
* Go to administration > patron restrictions
* Search for a specific restrictions
* Verify you can't make the 'You searched for' above the results table show
* Apply patch
* Everything should appear unchanged
Comment 4 Katrin Fischer 2023-02-20 23:10:50 UTC
Created attachment 146986 [details] [review]
Bug 32215: Remove unused "Your searched for" lines from patron restrictions admin page

To test:
* Go to administration > patron restrictions
* Search for a specific restrictions
* Verify you can't make the 'You searched for' above the results table show
* Apply patch
* Everything should appear unchanged
Comment 5 Matt Blenkinsop 2023-02-21 09:45:25 UTC
Created attachment 147018 [details] [review]
Bug 32215: Remove unused "Your searched for" lines from patron restrictions admin page

To test:
* Go to administration > patron restrictions
* Search for a specific restrictions
* Verify you can't make the 'You searched for' above the results table show
* Apply patch
* Everything should appear unchanged

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 6 Jonathan Druart 2023-02-23 09:39:48 UTC
Created attachment 147206 [details] [review]
Bug 32215: Remove unused "Your searched for" lines from patron restrictions admin page

To test:
* Go to administration > patron restrictions
* Search for a specific restrictions
* Verify you can't make the 'You searched for' above the results table show
* Apply patch
* Everything should appear unchanged

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Tomás Cohen Arazi 2023-02-27 14:42:13 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-03-01 09:51:11 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 9 Lucas Gass 2023-03-10 14:18:33 UTC
Missing dependencies for 22.05.x, no backport.