To test : 1. Go to Lists in the intranet. 2. Add a list by clicking on "New list". Choose a random name for it and select private or public and save. 3.Add one or more items into it and save. 4.Go back to the main page and select "Cataloging". 5.Go to "Batch record deletion". 6.In "upload a file" select "Select a list of records" and choose a list and keep the Bibliographic on. 7.Select continue and see that the list of records is not shown.
Confirmed on master.
Created attachment 143975 [details] [review] Bug 32237 : Batch delete records "no record IDs defined". List of records not shown. To test patch carry out the same procedure.
Hi Geraud, please add a problem/solution description and the full test plans to the commit messages. This might be helpful: https://wiki.koha-community.org/wiki/Commit_messages
Created attachment 143976 [details] [review] Bug 32237: Fix using a list as base for batch record deletion When a list was used to select records for batch deletion, the record IDs were no longer found. To test: 1. Go to Lists in the intranet. 2. Add a list by clicking on "New list". Choose a random name for it and select private or public and save. 3.Add one or more items into it and save. 4.Go back to the main page and select "Cataloging". 5.Go to "Batch record deletion". 6.In "upload a file" select "Select a list of records" and choose a list and keep the Bibliographic on. 7.Select continue and see that the list of records is not shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
QA: Looking here
Created attachment 144049 [details] [review] Bug 32237: Fix using a list as base for batch record deletion When a list was used to select records for batch deletion, the record IDs were no longer found. To test: 1. Go to Lists in the intranet. 2. Add a list by clicking on "New list". Choose a random name for it and select private or public and save. 3.Add one or more items into it and save. 4.Go back to the main page and select "Cataloging". 5.Go to "Batch record deletion". 6.In "upload a file" select "Select a list of records" and choose a list and keep the Bibliographic on. 7.Select continue and see that the list of records is not shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 22.11. Nice work everyone, thanks!
Any chance this can be backported to 22.05?
Yes, please! I would love to see this backported to 22.05. I use this feature frequently.
Please backport 22.05!
same here! We just discovered it wasn't working in 22.05.07.
Backported to 22.05.x for upcoming 22.05.10
can't reproduce on 21.11.x, won't backport