Bug 32245 - Deleting news entries from Koha's staff start page is broken
Summary: Deleting news entries from Koha's staff start page is broken
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Marcel de Rooy
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 31383
  Show dependency treegraph
 
Reported: 2022-11-17 11:52 UTC by Katrin Fischer
Modified: 2023-12-28 20:47 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 32245: Fix delete news item from staff home page (1.80 KB, patch)
2023-06-22 13:33 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32245: Fix delete news item from staff home page (1.77 KB, patch)
2023-06-22 21:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-17 11:52:39 UTC
When you try to delete a news entry from Koha's staff start page you get the confirmation question, but when you say yes, you end up in the HTML customizations with an empty page. The news entry is not deleted.
Comment 1 Katrin Fischer 2023-06-10 23:14:22 UTC
Still valid.
Comment 2 Marcel de Rooy 2023-06-22 13:33:59 UTC
Created attachment 152561 [details] [review]
Bug 32245: Fix delete news item from staff home page

Simple fix: op was named incorrectly in URL.
Comment 3 Marcel de Rooy 2023-06-22 13:34:23 UTC
Trivial. Self signoff
Comment 4 Marcel de Rooy 2023-06-22 13:34:56 UTC
Please test on top of 31383. Ready soon for QA.
Comment 5 Marcel de Rooy 2023-06-22 14:03:20 UTC
RMaints: This should be trivial to backport without 31383.
Comment 6 Katrin Fischer 2023-06-22 21:49:26 UTC
Currently the patch doesn't apply without 32245:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 32245: Fix delete news item from staff home page
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 32245: Fix delete news item from staff home page
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-32245-Fix-delete-news-item-from-staff-home-pag-c87n5g8w.patch

As we want the bugfix backported, I suggest to turn the dependencies around.
Comment 7 Katrin Fischer 2023-06-22 21:52:49 UTC
Created attachment 152603 [details] [review]
Bug 32245: Fix delete news item from staff home page

Simple fix: op was named incorrectly in URL.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi 2023-06-23 12:45:57 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Martin Renvoize 2023-07-17 12:45:28 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 10 Pedro Amorim 2023-07-18 10:50:04 UTC
Nice work everyone!

Pushed to 22.11.x for next release