Bug 32252 - Number of results in a facet do not show after facet selection
Summary: Number of results in a facet do not show after facet selection
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Eric Garcia
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-17 16:00 UTC by Catrina Berka
Modified: 2024-11-18 17:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 32252: Show number of results after facet selection (1.79 KB, patch)
2024-07-02 15:34 UTC, Eric Garcia 		Details | Diff | Splinter Review
Bug 32252: Show number of results after facet selection (1.84 KB, patch)
2024-07-02 21:58 UTC, Roman Dolny 		Details | Diff | Splinter Review
Bug 32252: Show number of results after facet selection (1.92 KB, patch)
2024-07-02 22:43 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Catrina Berka 2022-11-17 16:00:19 UTC 
Bug 27035 was supposed to show the number of results in a facet after selection, but the old behavior persists, only showing [x] that the facet has been selected, not the (n) indicating the number of results. 

This screencast shows the results on the staff interface: https://watch.screencastify.com/v/rWbvqeBLY7hXTex8TekX
Comment 1 Katrin Fischer 2022-11-17 16:33:21 UTC 
Hi Catrina, did you set displayFacetCount to show?
Comment 2 Catrina Berka 2022-11-17 16:44:13 UTC 
Yes, displayFacetCount = show
Comment 3 Lucas Gass (lukeg) 2022-11-17 19:28:13 UTC 
Confirmed on master. In the staff client the (n) will not show after making a selection, only the [x].

However, it does show the number after making a selection when searching in the OPAC. 

Ultimately, they should function the same.
Comment 4 Eric Garcia 2024-07-02 15:34:56 UTC 
Created attachment 168383 [details] [review]
Bug 32252: Show number of results after facet selection

To test:
1. In system preferences, set displatFacetCount to show.
2. Search catalog and select a facet.
3. Notice next to the facet it only shows [x], and not (n) the indicated number of results.
4. Apply patch.
5. Search catalog and select a facet.
6. Notice next to the facet it now shows (n) the indicated number of results and [x] to deselect the facet.
Comment 5 Roman Dolny 2024-07-02 21:58:07 UTC 
Created attachment 168408 [details] [review]
Bug 32252: Show number of results after facet selection

To test:
1. In system preferences, set displatFacetCount to show.
2. Search catalog and select a facet.
3. Notice next to the facet it only shows [x], and not (n) the indicated number of results.
4. Apply patch.
5. Search catalog and select a facet.
6. Notice next to the facet it now shows (n) the indicated number of results and [x] to deselect the facet.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 6 Lucas Gass (lukeg) 2024-07-02 22:43:40 UTC 
Created attachment 168412 [details] [review]
Bug 32252: Show number of results after facet selection

To test:
1. In system preferences, set displatFacetCount to show.
2. Search catalog and select a facet.
3. Notice next to the facet it only shows [x], and not (n) the indicated number of results.
4. Apply patch.
5. Search catalog and select a facet.
6. Notice next to the facet it now shows (n) the indicated number of results and [x] to deselect the facet.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Mentored-by: ByWater Solutions
Comment 7 Katrin Fischer 2024-07-05 13:50:23 UTC 
Pushed for 24.11!

Well done everyone, thank you!