Several pages listed on the Tools page need the page-section container: - patroncards/edit-batch.tt - pos/register.tt - pos/registers.tt - tools/access_files.tt - tools/additional-contents.tt - tools/batch_extend_due_dates.tt - tools/modborrowers.tt - tools/picture-upload.tt - tools/upload.tt
Created attachment 144018 [details] [review] Bug 32254: Add 'page-section' to various tools pages This patch adds a .page-section div to various pages in the tools section in order to provide a consistent page structure. Also changed: Corrected a couple of templates which were missing some <tr> tags. This patch includes indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Tools -> Access files - Tools -> HTML customizations - Additional contents, news or pages-- all use the same template. - Check the list of existing entries. - Tools -> Batch extend due dates - Choose a set of criteria that will return results and click "Continue". - Check the list of checkouts to be updated. - Tools -> Batch patron modification - Submit a batch of patrons for modification. - Check the list of patrons to be modified. - Tools -> Upload patron images - Upload one or more patron images - Check the view of results - Tools -> Upload - Upload a file and view the results, or perform a search and check the view of results. - Tools -> Patron card creator -> New patron card batch. - Submit a set of patrons and check the display of patrons in the resulting batch. - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - Confirm that the table of data looks correct
Created attachment 144025 [details] [review] Bug 32254: Add 'page-section' to various tools pages This patch adds a .page-section div to various pages in the tools section in order to provide a consistent page structure. Also changed: Corrected a couple of templates which were missing some <tr> tags. This patch includes indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Tools -> Access files - Tools -> HTML customizations - Additional contents, news or pages-- all use the same template. - Check the list of existing entries. - Tools -> Batch extend due dates - Choose a set of criteria that will return results and click "Continue". - Check the list of checkouts to be updated. - Tools -> Batch patron modification - Submit a batch of patrons for modification. - Check the list of patrons to be modified. - Tools -> Upload patron images - Upload one or more patron images - Check the view of results - Tools -> Upload - Upload a file and view the results, or perform a search and check the view of results. - Tools -> Patron card creator -> New patron card batch. - Submit a set of patrons and check the display of patrons in the resulting batch. - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - Confirm that the table of data looks correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 144026 [details] [review] Bug 32254: (follow-up) Add page section to Cashup history Adds one missing page section on the last table of the POS transactions page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
A follow-up is also needed for the "Older transactions" section:* 1. Go to Transaction history for 2. In the "Older transactions" section enter a from date, for example: 1 November 2022 3. Click "Display" 4. Result: table (with no entries) has no page-section * Need to enable the UseCashRegisters system preference and add a cash register
Created attachment 144074 [details] [review] Bug 32254: (follow-up) Add missing div around "Older transactions" To test: - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - In the "Older transactions" section, submit start and end dates which will return results. - The table of results should be styled correctly.
Created attachment 144079 [details] [review] Bug 32254: Add 'page-section' to various tools pages This patch adds a .page-section div to various pages in the tools section in order to provide a consistent page structure. Also changed: Corrected a couple of templates which were missing some <tr> tags. This patch includes indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Tools -> Access files - Tools -> HTML customizations - Additional contents, news or pages-- all use the same template. - Check the list of existing entries. - Tools -> Batch extend due dates - Choose a set of criteria that will return results and click "Continue". - Check the list of checkouts to be updated. - Tools -> Batch patron modification - Submit a batch of patrons for modification. - Check the list of patrons to be modified. - Tools -> Upload patron images - Upload one or more patron images - Check the view of results - Tools -> Upload - Upload a file and view the results, or perform a search and check the view of results. - Tools -> Patron card creator -> New patron card batch. - Submit a set of patrons and check the display of patrons in the resulting batch. - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - Confirm that the table of data looks correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David <david@davidnind.com>
Created attachment 144080 [details] [review] Bug 32254: (follow-up) Add page section to Cashup history Adds one missing page section on the last table of the POS transactions page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David <david@davidnind.com>
Created attachment 144081 [details] [review] Bug 32254: (follow-up) Add missing div around "Older transactions" To test: - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - In the "Older transactions" section, submit start and end dates which will return results. - The table of results should be styled correctly. Signed-off-by: David <david@davidnind.com>
Created attachment 144091 [details] [review] Bug 32254: (follow-up) Add missing div around "Older transactions" To test: - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - In the "Older transactions" section, submit start and end dates which will return results. - The table of results should be styled correctly. Signed-off-by: David <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!