When searching in the cataloguing module, the results page needs page-sectioning for both areas: local results and results in the reservoir.
Created attachment 144111 [details] [review] Bug_32298 - Page section added to cataloguing search Div added to "Records found in this catalog", page section class added to "Records found in the reservoir". Level two heading changed and horizontal line removed as it is now superfluous Test plan: 1) Apply patch from bug 32298 2) Navigate to Cataloging 3) Enter a search into the search field and run the search 4) Verify that the white page section identifier is now visible around both sections
Created attachment 144118 [details] [review] Bug_32298 - Page section added to cataloguing search Div added to "Records found in this catalog", page section class added to "Records found in the reservoir". Level two heading changed and horizontal line removed as it is now superfluous Test plan: 1) Apply patch from bug 32298 2) Navigate to Cataloging 3) Enter a search into the search field and run the search 4) Verify that the white page section identifier is now visible around both sections Signed-off-by: Hammat Wele <hammat.wele@inlibro.com>
Created attachment 144119 [details] [review] Bug 32298: Page section added to cataloguing search Div added to "Records found in this catalog", page section class added to "Records found in the reservoir". Level two heading changed and horizontal line removed as it is now superfluous Test plan: 1) Apply patch from bug 32298 2) Navigate to Cataloging 3) Enter a search into the search field and run the search 4) Verify that the white page section identifier is now visible around both sections Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Katrin <katrin.fischer.83@web.de>
Hi Matt, congrats on your first patch! :) Some small stuff: * The commit message always needs to start with: Bug XXXX: - this helps with our tools and also gives some consistency in the commit message. You can find information on how to write good commit messages in the wiki: https://wiki.koha-community.org/wiki/Commit_messages. If you run the qa test tools on your patches, they will also alert you of issues like this. on ktd in the shell: qa -v 2 * Not a problem, but maybe you'd want to change the first bit to use a formatted name: mattblenkinsop <matt.blenkinsop@ptfs-europe.com>. This should come from GIT_USER_NAME= in the .env of ktd. I have Katrin Fischer there and it works with the blank and without quotes.
Created attachment 144150 [details] [review] Bug 32298: Page section added to cataloguing search Added div to "Records found in this catalog". Added page-section class to "Records found in the reservoir". Corrected level two heading and removed horizontal line as it is now superfluous. Test plan: 1) Apply patch from bug 32298 2) Navigate to Cataloging 3) Enter a search into the search field and run the search 4) Verify that the white page section identifier is now visible around both sections Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: PTFS Europe Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Katrin <katrin.fischer.83@web.de>
Created attachment 144151 [details] [review] Bug 32298: Page section added to cataloguing search Added div to "Records found in this catalog". Added page-section class to "Records found in the reservoir". Corrected level two heading and removed horizontal line as it is now superfluous. Test plan: 1) Apply patch from bug 32298 2) Navigate to Cataloging 3) Enter a search into the search field and run the search 4) Verify that the white page section identifier is now visible around both sections Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: PTFS Europe Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Katrin <katrin.fischer.83@web.de>
Minor commit message fixes, added mentorship and sponsorship details and correct full name on committer.
Interesting, I am missing my last name. This was the first patch I signed from the new laptop, will have to go check.
Pushed to master for 22.11. Nice work everyone, thanks!