Bug 32298 - Add page-section to cataloguing search results (cat)
Summary: Add page-section to cataloguing search results (cat)
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Matt Blenkinsop
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/cataloguing/addbooks.pl
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-11-20 12:59 UTC by Katrin Fischer
Modified: 2023-06-08 22:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug_32298 - Page section added to cataloguing search (2.06 KB, patch)
2022-11-21 15:41 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug_32298 - Page section added to cataloguing search (2.10 KB, patch)
2022-11-21 20:15 UTC, Hammat wele
Details | Diff | Splinter Review
Bug 32298: Page section added to cataloguing search (2.15 KB, patch)
2022-11-21 20:28 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32298: Page section added to cataloguing search (2.24 KB, patch)
2022-11-22 11:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32298: Page section added to cataloguing search (2.24 KB, patch)
2022-11-22 11:56 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-20 12:59:32 UTC
When searching in the cataloguing module, the results page needs page-sectioning for both areas: local results and results in the reservoir.
Comment 1 Matt Blenkinsop 2022-11-21 15:41:46 UTC
Created attachment 144111 [details] [review]
Bug_32298 - Page section added to cataloguing search

Div added to "Records found in this catalog", page section class added to "Records found in the reservoir". Level two heading changed and horizontal line removed as it is now superfluous

Test plan:
1) Apply patch from bug 32298
2) Navigate to Cataloging
3) Enter a search into the search field and run the search
4) Verify that the white page section identifier is now visible around both sections
Comment 2 Hammat wele 2022-11-21 20:15:54 UTC
Created attachment 144118 [details] [review]
Bug_32298 - Page section added to cataloguing search

Div added to "Records found in this catalog", page section class added to "Records found in the reservoir". Level two heading changed and horizontal line removed as it is now superfluous

Test plan:
1) Apply patch from bug 32298
2) Navigate to Cataloging
3) Enter a search into the search field and run the search
4) Verify that the white page section identifier is now visible around both sections

Signed-off-by: Hammat Wele <hammat.wele@inlibro.com>
Comment 3 Katrin Fischer 2022-11-21 20:28:42 UTC
Created attachment 144119 [details] [review]
Bug 32298: Page section added to cataloguing search

Div added to "Records found in this catalog", page section class added to "Records found in the reservoir". Level two heading changed and horizontal line removed as it is now superfluous

Test plan:
1) Apply patch from bug 32298
2) Navigate to Cataloging
3) Enter a search into the search field and run the search
4) Verify that the white page section identifier is now visible around both sections

Signed-off-by: Hammat Wele <hammat.wele@inlibro.com>

Signed-off-by: Katrin <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-11-21 20:29:27 UTC
Hi Matt, 

congrats on your first patch! :)

Some small stuff:

* The commit message always needs to start with: Bug XXXX: - this helps with our tools and also gives some consistency in the commit message. You can find information on how to write good commit messages in the wiki: https://wiki.koha-community.org/wiki/Commit_messages. If you run the qa test tools on your patches, they will also alert you of issues like this. on ktd in the shell: qa -v 2

* Not a problem, but maybe you'd want to change the first bit to use a formatted name: mattblenkinsop <matt.blenkinsop@ptfs-europe.com>. This should come from GIT_USER_NAME= in the .env of ktd. I have Katrin Fischer there and it works with the blank and without quotes.
Comment 5 Martin Renvoize 2022-11-22 11:54:55 UTC
Created attachment 144150 [details] [review]
Bug 32298: Page section added to cataloguing search

Added div to "Records found in this catalog".
Added page-section class to "Records found in the reservoir".
Corrected level two heading and removed horizontal line as it is now superfluous.

Test plan:
1) Apply patch from bug 32298
2) Navigate to Cataloging
3) Enter a search into the search field and run the search
4) Verify that the white page section identifier is now visible around both sections

Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sponsored-by: PTFS Europe
Signed-off-by: Hammat Wele <hammat.wele@inlibro.com>
Signed-off-by: Katrin <katrin.fischer.83@web.de>
Comment 6 Martin Renvoize 2022-11-22 11:56:21 UTC
Created attachment 144151 [details] [review]
Bug 32298: Page section added to cataloguing search

Added div to "Records found in this catalog".
Added page-section class to "Records found in the reservoir".
Corrected level two heading and removed horizontal line as it is now superfluous.

Test plan:
1) Apply patch from bug 32298
2) Navigate to Cataloging
3) Enter a search into the search field and run the search
4) Verify that the white page section identifier is now visible around both sections

Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sponsored-by: PTFS Europe
Signed-off-by: Hammat Wele <hammat.wele@inlibro.com>
Signed-off-by: Katrin <katrin.fischer.83@web.de>
Comment 7 Martin Renvoize 2022-11-22 11:57:09 UTC
Minor commit message fixes, added mentorship and sponsorship details and correct full name on committer.
Comment 8 Katrin Fischer 2022-11-22 12:02:35 UTC
Interesting, I am missing my last name. This was the first patch I signed from the new laptop, will have to go check.
Comment 9 Tomás Cohen Arazi 2022-11-22 12:31:32 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!