Bug 32320 - Remove text-shadow from header menu links
Summary: Remove text-shadow from header menu links
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-22 12:09 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01


Attachments
Bug 32320: Remove text-shadow from header menu links (1.12 KB, patch)
2022-11-22 12:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32320: Remove text-shadow from header menu links (1.18 KB, patch)
2022-11-22 17:16 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32320: Remove text-shadow from header menu links (1.23 KB, patch)
2022-12-07 21:37 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-22 12:09:30 UTC
The header menu inherits a text-shadow from Bootstrap which is subtle but makes the links look slightly fuzzy. It should be removed.
Comment 1 Owen Leonard 2022-11-22 12:16:13 UTC
Created attachment 144153 [details] [review]
Bug 32320: Remove text-shadow from header menu links

This patch unsets the text-shadow style on links in the header menu.
This makes the links look a little crisper. The style is inherited from
Bootstrap's defaults and is incorrect for our design.

To test, apply the patch and rebuild the staff interface CSS.

View any page in the staff interface to confirm that header menu links
look correct.
Comment 2 Lucas Gass 2022-11-22 17:16:18 UTC
Created attachment 144167 [details] [review]
Bug 32320: Remove text-shadow from header menu links

This patch unsets the text-shadow style on links in the header menu.
This makes the links look a little crisper. The style is inherited from
Bootstrap's defaults and is incorrect for our design.

To test, apply the patch and rebuild the staff interface CSS.

View any page in the staff interface to confirm that header menu links
look correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2022-12-07 21:37:26 UTC
Created attachment 144494 [details] [review]
Bug 32320: Remove text-shadow from header menu links

This patch unsets the text-shadow style on links in the header menu.
This makes the links look a little crisper. The style is inherited from
Bootstrap's defaults and is incorrect for our design.

To test, apply the patch and rebuild the staff interface CSS.

View any page in the staff interface to confirm that header menu links
look correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-12-13 12:27:33 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2022-12-15 13:39:04 UTC
Nice work everyone!

Pushed to 22.11.x for the next release