t/db_dependent/Koha/Patron.t .. # Failed test 'Exception thrown on unique attribute' # at t/db_dependent/Koha/Patron.t line 251. # expecting: Koha::Exceptions::Patron::Attribute::UniqueIDConstraint # found: normal exit # Failed test 'Extended attributes storing rolled back' # at t/db_dependent/Koha/Patron.t line 255. # got: '2' # expected: '0' # Looks like you failed 2 tests of 5. # Failed test 'unique attributes tests' # at t/db_dependent/Koha/Patron.t line 259. # Looks like you failed 1 test of 16. t/db_dependent/Koha/Patron.t .. 1/1 # Failed test 'extended_attributes' # at t/db_dependent/Koha/Patron.t line 393.
Created attachment 144223 [details] [review] Bug 32343: Prevent Koha/Patron.t to fail randomly Highlighted by Bug 32030: fix test builder for boolean The attribute is named "unique_id", not "unique"
Created attachment 144224 [details] [review] Bug 32343: Prevent Koha/Patron.t to fail randomly Highlighted by Bug 32030: fix test builder for boolean The attribute is named "unique_id", not "unique" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Fix confirmed, going straight for QA. Passed
This makes me wonder however.. should we be throwing errors in testbuilder if we're passed unrecognised fields in the values param?
(In reply to Martin Renvoize from comment #4) > This makes me wonder however.. should we be throwing errors in testbuilder > if we're passed unrecognised fields in the values param? Bue 32350
Pushed to master for 22.11. Nice work everyone, thanks!