Currently the ExcludeHolidaysFromMaxPickUpDelay is an on or off function.  This is problematic with libraries that are closed several days in a week.  It would be helpful if there were a threshold that could be set for this setting.  The question would be, what kind of a threshold?

For example, if ReservesMaxPickUpDelay is set to 7, and a pickup library is closed for 4 days in a week, if ExcludeHolidaysFromMaxPickUpDelay does not use the calendar, the expiration on the waiting hold will likely fall on a closed day, and also reduce the number of opportunities to be picked up.  However, if ExcludeHolidaysFromMaxPickUpDelay is set to use the calendar, that same library will end up holding the item for more than two weeks to fulfill the 7 days.

If ExcludeHolidaysFromMaxPickUpDelay uses the calendar, it would be helpful if there were an option to extend the ReservesMaxPickUpDelay to the closest open day past the closed dates.  Perhaps something like MaxReservePickupExtentension, in which if it is blank or set to 0, it does nothing, like Koha does currently, but if it is set to a number of days, it would extend the expiration past the close date to the next open day that falls within the number of days defined. 

For example, ReservesMaxPickUpDelay is set to 7, and our proposed MaxReservePickupExtentension setting is set to 7 as well, and the pickup library is closed Sunday, Monday, Wednesday, and Friday.  The pickup library receives the item on Tuesday, and instead of expiring on the following Monday when they are closed, Koha would look to the next open day (within 7 days past ReservesMaxPickUpDelay), which would be the following Tuesday.  If there is no open days within the extra days defined in MaxReservePickupExtentension, it would keep the original expiration date, or more accurately, expire on the last open day before the closed expiration date.

I hope that makes sense.