Bug 32400 - Add page-section to tables for end of year rollover (acq)
Summary: Add page-section to tables for end of year rollover (acq)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-12-03 22:51 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.02


Attachments
Bug 32400: Add page-section to aqbudgetperiods table (5.45 KB, patch)
2023-01-04 18:41 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32400: Add page-section to aqbudgetperiods table (5.50 KB, patch)
2023-01-04 19:57 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32400: Add page-section to aqbudgetperiods table (5.50 KB, patch)
2023-01-06 23:49 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32400: (follow-up) Add page-section to table of moved orders (5.59 KB, patch)
2023-01-06 23:49 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32400: Add page-section to aqbudgetperiods table (5.56 KB, patch)
2023-01-07 00:00 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32400: (follow-up) Add page-section to table of moved orders (5.65 KB, patch)
2023-01-07 00:00 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-12-03 22:51:05 UTC
When closing a budget, you will see a list of all funds with the pending orders in each. This one needs a page section.
When you have picked a budget and submit that page, it shows you a table with the orders that have been moved to the new budget's funds. This also needs one.
Comment 1 Lucas Gass 2023-01-04 18:41:58 UTC
Created attachment 145040 [details] [review]
Bug 32400: Add page-section to aqbudgetperiods table

To test:
1. Apply patch
2. Go to Administration -> Budgets
3. Close a budget
4. Make sure the page-section looks right.
Comment 2 ByWater Sandboxes 2023-01-04 19:57:32 UTC
Created attachment 145045 [details] [review]
Bug 32400: Add page-section to aqbudgetperiods table

To test:
1. Apply patch
2. Go to Administration -> Budgets
3. Close a budget
4. Make sure the page-section looks right.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Katrin Fischer 2023-01-06 23:35:27 UTC
This patch doesn't fix what was reported :(
Comment 4 Katrin Fischer 2023-01-06 23:39:39 UTC
(In reply to Katrin Fischer from comment #3)
> This patch doesn't fix what was reported :(

Actually, I need to be more careful at this time of day with my comments. It's a partial fix, I'll provide the second half.
Comment 5 Katrin Fischer 2023-01-06 23:49:32 UTC
Created attachment 145117 [details] [review]
Bug 32400: Add page-section to aqbudgetperiods table

To test:
1. Apply patch
2. Go to Administration -> Budgets
3. Close a budget
4. Make sure the page-section looks right.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 6 Katrin Fischer 2023-01-06 23:49:36 UTC
Created attachment 145118 [details] [review]
Bug 32400: (follow-up) Add page-section to table of moved orders

To test:
* Make sure you have at least one open order, basket closed
* Go to Administration > budgets
* Clone the budget
* Close the budget
* Choose your new budget and save
* Confirm 'can't undo later...' question
* Verify the table of moved orders has the white background
  from the added page-section
Comment 7 Katrin Fischer 2023-01-07 00:00:00 UTC
Created attachment 145119 [details] [review]
Bug 32400: Add page-section to aqbudgetperiods table

To test:
1. Apply patch
2. Go to Administration -> Budgets
3. Close a budget
4. Make sure the page-section looks right.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2023-01-07 00:00:07 UTC
Created attachment 145120 [details] [review]
Bug 32400: (follow-up) Add page-section to table of moved orders

To test:
* Make sure you have at least one open order, basket closed
* Go to Administration > budgets
* Clone the budget
* Close the budget
* Choose your new budget and save
* Confirm 'can't undo later...' question
* Verify the table of moved orders has the white background
  from the added page-section

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2023-01-11 23:55:34 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Jacob O'Mara 2023-01-13 16:24:52 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.