Bug 32516 - SIP2 no block flag on renewals is passed, but not used
Summary: SIP2 no block flag on renewals is passed, but not used
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 12225
Blocks:
  Show dependency tree / graph
 
Reported: 2022-12-22 14:13 UTC by Nick Clemens (kidclamp)
Modified: 2023-09-12 16:52 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2022-12-22 14:13:52 UTC 
C4/SIP/ILS.pm
429 sub renew {
430     my ($self, $patron_id, $patron_pwd, $item_id, $title_id,
431     $no_block, $nb_due_date, $third_party,

no_block does not appear elsewhere in the routine
Comment 1 Nick Clemens (kidclamp) 2022-12-27 20:28:56 UTC 
Marking as major - this is a behaviour change from bug 12225 - it seems we have allowed machines to send the no-block in the past and treated it as a normal checkin - now we die on calling a non-existent routine

We should add real support for this, but until we do we should stop failing
Comment 2 Martin Renvoize (ashimema) 2023-09-12 16:30:42 UTC 
Is this still a major Nick?

I've just stumbled into it when working through fee acknowledgement fixes.. but I must admit, I've not come across this one in real life yet.
Comment 3 Nick Clemens (kidclamp) 2023-09-12 16:52:58 UTC 
I think we saw that some vendors started failing on upgrade because of this, and that's why I marked major. Bug 32515 may have mitigated the issue for us. Marking as normal