Bug 32568 - Add page section to list of checkins
Summary: Add page section to list of checkins
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-04 16:35 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patch adds the page-section class to the checkedin table on the returns page.
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32568: Add page-section to checkedin table (18.30 KB, patch)
2023-01-04 17:44 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32568: Add page-section to checkedin table (18.36 KB, patch)
2023-01-04 19:40 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32568: Add page-section to checkedin table (18.46 KB, patch)
2023-02-24 10:12 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-01-04 16:35:14 UTC
When you check in one or more items, the list of checkins is missing the page-section class that woudl give it a white background.
Comment 1 Lucas Gass 2023-01-04 17:44:43 UTC
Created attachment 145038 [details] [review]
Bug 32568: Add page-section to checkedin table

To test:
1. Apply patch
2. Checkin some items that are checked out/
3. Make sure the page-section looks right.

Note: There are some indentation changes.
Comment 2 ByWater Sandboxes 2023-01-04 19:40:05 UTC
Created attachment 145044 [details] [review]
Bug 32568: Add page-section to checkedin table

To test:
1. Apply patch
2. Checkin some items that are checked out/
3. Make sure the page-section looks right.

Note: There are some indentation changes.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Marcel de Rooy 2023-02-24 10:12:20 UTC
Created attachment 147288 [details] [review]
Bug 32568: Add page-section to checkedin table

To test:
1. Apply patch
2. Checkin some items that are checked out/
3. Make sure the page-section looks right.

Note: There are some indentation changes.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2023-02-24 20:38:44 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-02-28 17:08:38 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass 2023-03-08 13:56:14 UTC
Missing dependencies for 22.05.x, no backport.