Bug 32574 - memberresultst table cannot be column configured in 22.05.x
Summary: memberresultst table cannot be column configured in 22.05.x
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 22.05
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-05 18:02 UTC by Lucas Gass (lukeg)
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes an issue with configuring the columns for patron search results in Koha 22.05 - this should now work as expected. The columns are now configurable using the Columns button in the search results and in the table settings (Administration > Additional parameters > Table settings > Patrons > member > memberresultst).
Version(s) released in:
22.05.10
Circulation function:

Attachments
Bug 32574: [22.05] Fix table settings on member.tt (1.35 KB, patch)
2023-01-05 18:07 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 32574: [22.05] Fix table settings on member.tt (1.40 KB, patch)
2023-01-05 18:41 UTC, David Nind 		Details | Diff | Splinter Review
Bug 32574: [22.05] Fix table settings on member.tt (1.47 KB, patch)
2023-01-05 19:17 UTC, Caroline Cyr La Rose 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-01-05 18:02:53 UTC 
memberresultst needs to use TablesSettings.GetTableSettings but it is using TablesSettings.GetColumns so table settings don't work.
Comment 1 Lucas Gass (lukeg) 2023-01-05 18:07:11 UTC 
Created attachment 145068 [details] [review]
Bug 32574: [22.05] Fix table settings on member.tt

To test:
1. Apply patch
2. Do a patron searches that will return mutiple patrons.
3. Make sure you see the Columns button
4. Make sure you can properly hide columns via Table settings
Comment 2 David Nind 2023-01-05 18:41:33 UTC 
Created attachment 145069 [details] [review]
Bug 32574: [22.05] Fix table settings on member.tt

To test:
1. Apply patch
2. Do a patron searches that will return mutiple patrons.
3. Make sure you see the Columns button
4. Make sure you can properly hide columns via Table settings

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Caroline Cyr La Rose 2023-01-05 19:17:08 UTC 
Created attachment 145073 [details] [review]
Bug 32574: [22.05] Fix table settings on member.tt

To test:
1. Apply patch
2. Do a patron searches that will return mutiple patrons.
3. Make sure you see the Columns button
4. Make sure you can properly hide columns via Table settings

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 4 Marcel de Rooy 2023-02-24 10:19:58 UTC 
Confusing area:

koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc:function KohaTable(id_selector, dt_parameters, table_settings, add_filters) {

koha-tmpl/opac-tmpl/bootstrap/en/includes/columns_settings.inc:function KohaTable(selector, dt_parameters, columns_settings) {

First glance this looks wrong too:

koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:        table_settings = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %];
Comment 5 Marcel de Rooy 2023-02-24 10:23:21 UTC 
But this looks good and should be pushed further to the right RMaint queue.
Comment 6 Lucas Gass (lukeg) 2023-02-24 13:23:29 UTC 
Backported to 22.05.x to upcoming 22.05.10
Comment 7 Arthur Suzuki 2023-02-28 07:43:21 UTC 
can't reproduce on 21.11.x, won't backport