Edifact status appear to vary between all lower case and being capitalized. This breaks the switch in the edi_status block of the basket.tt template. We should make this switch case-insensitive.
Created attachment 145405 [details] [review] Bug 32676: EDI message status uses varying case, breaking EDI status block Edifact status appear to vary between all lower case and being capitalized. This breaks the switch in the edi_status block of the basket.tt template. We should make this switch case-insensitive. Test Plan: 1) View the basket for a sent EDI order, not the Sent status does not display. 2) Apply this patch 3) Reload the page, note the status is now visible!
Created attachment 145758 [details] [review] Bug 32676: EDI message status uses varying case, breaking EDI status block Edifact status appear to vary between all lower case and being capitalized. This breaks the switch in the edi_status block of the basket.tt template. We should make this switch case-insensitive. Test Plan: 1) View the basket for a sent EDI order, not the Sent status does not display. 2) Apply this patch 3) Reload the page, note the status is now visible! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All works as expected, nice clean fix. Going straight for QA here. Passing.
Please rebase.
I've been hit with the git-bz unicode error again, so here's the patch: https://github.com/bywatersolutions/bywater-koha-devel/tree/bug_32676
(In reply to Tomás Cohen Arazi from comment #6) > Please rebase. Rebased! Code is available at: https://github.com/bywatersolutions/bywater-koha-devel/tree/bug_32676
(should have been switched back to PQA instead of Signed Off)
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x