With intranetreadinghistory it is an all or nothing option - there are often situations where staff will need to view this, but not necessarily every staff member needs to see the information. It would be great to add the ability to view this to the permissions so libraries can decided which staff have this ability.
Hear here! Great idea and as a consortium we are wholeheartedly behind this kind of development.
Created attachment 183844 [details] [review] Bug 32682: Add permission for viewing patron reading history
Created attachment 183845 [details] [review] Bug 32682: Implement reading history permission
Created attachment 183846 [details] [review] Bug 32682: Adjust atomicupdate permission
Is this ready for testing?
It's not quite ready yet--I'm still working on both a test plan and migrating over old functionality so that libraries don't experience a change in expected functionality.
Comment on attachment 183844 [details] [review] Bug 32682: Add permission for viewing patron reading history Review of attachment 183844 [details] [review]: ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_32682_add_permission.pl @@ +24,5 @@ > + # SELECT borrowernumber, 10, 'view_checkout_history' FROM user_permissions WHERE code = 'remaining_permissions' > + # } > + # ); > + > + # TODO: migrate libraries' "intranetreadinghistory" syspref (will this require us to not fully remove it until we're sure everyone has migrated off of it?) This is an interesting question. Technically, I think that you have to keep the intranetreadinghistory because it's impossible to replace it with permissions only. For instance, maybe you disable intranetreadinghistory via Apache configuration because you don't want anyone - even superlibrarians to be able to read the checkout history. If you have libraries with intranetreadinghistory turned off, then these patches will actually cause a regression where anyone with all borrowers permissions will be able to see the reading history when they couldn't previously.
Failing due to my above comment. On the plus side, with a small adjustment, I think that these patches would be nearly good to go. I suppose the only scenario not covered would be where intranetreadinghistory is enabled and you have limited borrower permissions and you used to be able to read the checkout history and now you can't... I suppose you could add another SQL update that adds the view_checkout_history permission if they had permission to view the pages that this is modifying...