Bug 31459 updated the dropdown and intended to restore this option, however, it looks like the template toolkit markers were missed: <option value="order.fund.budget.id" selected="selected" data-sort1-authcat="[% order.fund.sort1_authcat | html %]" data-sort2-authcat="[% order.fund.sort2_authcat | html %]"> Should be: <option value="[% order.fund.budget.id %]" selected="selected" data-sort1-authcat="[% order.fund.sort1_authcat | html %]" data-sort2-authcat="[% order.fund.sort2_authcat | html %]">
Workaround is to manually set the dropdown to the current budget
Hm, strange, I thought I had tested that explicitly? :(
Created attachment 145556 [details] [review] Bug 32694: Fix value of 'Keep current' option in receiving This patch restores missing template toolkit markers around the variable To test: 1 - Order an item in a basket 2 - Close the basket 3 - Attempt to receive the item, leaving budget as 'Keep current' 4 - 500 Error: C4::Acquisition::ModReceiveOrder(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (koha_cclsny.aqorders, CONSTRAINT aqorders_budget_id_fk FOREIGN KEY (budget_id) REFERENCES aqbudgets (budget_id) ON DELETE CASCADE ON UPDATE CASCADE) at /usr/share/koha/intranet/cgi-bin/acqui/finishreceive.pl line 120 5 - Apply patch 6 - Receive order successfully!
Created attachment 145564 [details] [review] Bug 32694: Fix value of 'Keep current' option in receiving This patch restores missing template toolkit markers around the variable To test: 1 - Order an item in a basket 2 - Close the basket 3 - Attempt to receive the item, leaving budget as 'Keep current' 4 - 500 Error: C4::Acquisition::ModReceiveOrder(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (koha_cclsny.aqorders, CONSTRAINT aqorders_budget_id_fk FOREIGN KEY (budget_id) REFERENCES aqbudgets (budget_id) ON DELETE CASCADE ON UPDATE CASCADE) at /usr/share/koha/intranet/cgi-bin/acqui/finishreceive.pl line 120 5 - Apply patch 6 - Receive order successfully! Signed-off-by: David Nind <david@davidnind.com>
Created attachment 145740 [details] [review] Bug 32694: Fix value of 'Keep current' option in receiving This patch restores missing template toolkit markers around the variable To test: 1 - Order an item in a basket 2 - Close the basket 3 - Attempt to receive the item, leaving budget as 'Keep current' 4 - 500 Error: C4::Acquisition::ModReceiveOrder(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (koha_cclsny.aqorders, CONSTRAINT aqorders_budget_id_fk FOREIGN KEY (budget_id) REFERENCES aqbudgets (budget_id) ON DELETE CASCADE ON UPDATE CASCADE) at /usr/share/koha/intranet/cgi-bin/acqui/finishreceive.pl line 120 5 - Apply patch 6 - Receive order successfully! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 145741 [details] [review] Bug 32694: (QA follow-up) Fix missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.10
applied to 21.11.x for 21.11.16
Not backported to 21.05.x