In the patron module, the list under 'Add to patron list' is not in alphabetical order
test plan 1. Go to Tools > Patron lists 2. Create a new patron list 3. Add 10 patrons in a random order (not in alphabetical nor in cardnumber sequence) 4. Go back to Tools > Patron lists management page 5. Find your list, click on "Action" and select "Print patron cards" 6. Check the cards order in the pdf --> notice these cards aren't in alphabetical order. Unfortunately, Koha sort them by the "patron_list_patron_id" order which it isn't always logical.
Created attachment 155468 [details] Bug 32742: Patron's lists option are not in alphabetical order This patch add sorting feature to the patron card lists export option To test 1. Go to Tools > Patron lists 2. Create a new patron list 3. Add 10 patrons in a random order (not in alphabetical nor in cardnumber sequence) 4. Go back to Tools > Patron lists management page 5. Find your list, click on 'Action' and select 'Print patron cards' 6. Check the cards order in the pdf --> notice these cards aren't in alphabetical order. 7. Apply the patch 8. Repeat step 4, 5 9. Fill the «Order by» field and submit 10. Check the cards order in the pdf --> notice the cards are now ordered.
Created attachment 155469 [details] [review] Bug 32742: Patron's lists option are not in alphabetical order This patch add sorting feature to the patron card lists export option To test 1. Go to Tools > Patron lists 2. Create a new patron list 3. Add 10 patrons in a random order (not in alphabetical nor in cardnumber sequence) 4. Go back to Tools > Patron lists management page 5. Find your list, click on 'Action' and select 'Print patron cards' 6. Check the cards order in the pdf --> notice these cards aren't in alphabetical order. 7. Apply the patch 8. Repeat step 4, 5 9. Fill the «Order by» field and submit 10. Check the cards order in the pdf --> notice the cards are now ordered.
Created attachment 155572 [details] [review] Bug 32742: Patron's lists option are not in alphabetical order This patch add sorting feature to the patron card lists export option To test 1. Go to Tools > Patron lists 2. Create a new patron list 3. Add 10 patrons in a random order (not in alphabetical nor in cardnumber sequence) 4. Go back to Tools > Patron lists management page 5. Find your list, click on 'Action' and select 'Print patron cards' 6. Check the cards order in the pdf --> notice these cards aren't in alphabetical order. 7. Apply the patch 8. Repeat step 4, 5 9. Fill the «Order by» field and submit 10. Check the cards order in the pdf --> notice the cards are now ordered. Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
I am running out of time here, so please fix these yourself: 1) Please perltidy: OK koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt WARN patroncards/create-pdf.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 181, now: 183) WARN patroncards/print.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 88, now: 90) 2) I feel like the Order by should be the last option in the form, going together with the "start with" option, instead of being the first in the form. 3) This should also be available when printing the patron cards from the patron card creator. Since the code for sorting is in patroncards/create-pdf.pl, I believe this would not require much more than a template change and it would give us nice consistency. 4) I think that if you change nothing the order will still be the order added ot the list - is this correct? (just a question, nothing to fix here)
Created attachment 167956 [details] [review] Bug 32742: Patron's lists option are not in alphabetical This patch add sorting feature to the patron card lists export option To test 1. Go to Tools > Patron lists 2. Create a new patron list 3. Add 10 patrons in a random order (not in alphabetical nor in cardnumber sequence) 4. Go back to Tools > Patron lists management page 5. Find your list, click on 'Action' and select 'Print patron cards' 6. Check the cards order in the pdf --> notice these cards aren't in alphabetical order. 7. Apply the patch 8. Repeat step 4, 5 9. Fill the «Order by» field and submit 10. Check the cards order in the pdf --> notice the cards are now ordered. It's also working for export in Patron card creator page. To test 1. Go to Tools > Patron card creator 2. Create a new patron card batch 3. Add some patrons 4. Test the "Order by" option for different export button 5. In an export form, Select the "Order by" field and submit 6. Check that it's ordered Export buttons : --> manage > card batches (or /cgi-bin/koha/patroncards/manage.pl?card_element=batch) > Export (from the table) > Select few batches > Export selected batches > Export from patron list --> Click "Edit" of your batch in the table > Export card batch > Export (from a row of the patrons table) note that this export doesn't need the order by option. > Select few patrons > Export selected card(s)
Created attachment 168069 [details] [review] Bug 32742: Patron's lists option are not in alphabetical This patch add sorting feature to the patron card lists export option To test 1. Go to Tools > Patron lists 2. Create a new patron list 3. Add 10 patrons in a random order (not in alphabetical nor in cardnumber sequence) 4. Go back to Tools > Patron lists management page 5. Find your list, click on 'Action' and select 'Print patron cards' 6. Check the cards order in the pdf --> notice these cards aren't in alphabetical order. 7. Apply the patch 8. Repeat step 4, 5 9. Fill the «Order by» field and submit 10. Check the cards order in the pdf --> notice the cards are now ordered. It's also working for export in Patron card creator page. To test 1. Go to Tools > Patron card creator 2. Create a new patron card batch 3. Add some patrons 4. Test the "Order by" option for different export button 5. In an export form, Select the "Order by" field and submit 6. Check that it's ordered Export buttons : --> manage > card batches (or /cgi-bin/koha/patroncards/manage.pl?card_element=batch) > Export (from the table) > Select few batches > Export selected batches > Export from patron list --> Click "Edit" of your batch in the table > Export card batch > Export (from a row of the patrons table) note that this export doesn't need the order by option. > Select few patrons > Export selected card(s)
Tried testing encountered Bug 37205
Created attachment 170786 [details] [review] Bug 32742: Patron's lists option are not in alphabetical order This patch add sorting feature to the patron card lists export option To test 1. Go to Tools > Patron lists 2. Create a new patron list 3. Add 10 patrons in a random order (not in alphabetical nor in cardnumber sequence) 4. Go back to Tools > Patron lists management page 5. Find your list, click on 'Action' and select 'Print patron cards' 6. Check the cards order in the pdf --> notice these cards aren't in alphabetical order. 7. Apply the patch 8. Repeat step 4, 5 9. Fill the «Order by» field and submit 10. Check the cards order in the pdf --> notice the cards are now ordered. Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Created attachment 170787 [details] [review] Bug 32742: (follow-up) Add sorting feature when printing the patron cards from the patron card creator This patch also put the «Order by» field at the last position in the form To test 1. Go to Tools > Patron card creator 2. Create a new Card batch 3. Add some patrons 4. Select all cards by clicking on checkbox in the select colunm 5. Click on «Export selected card(s)», an Export patron cards windows is opened 6. Fill the «Order by» field and submit 7. Check the cards order in the pdf --> notice the cards are now ordered. 8. Close the window opened in step 5 9. Click on «Export card batch», an Export patron cards windows is opened 10. repeat step 6 and 7 --> notice the cards are now ordered. 11. Close the window opened in step 9 12. Fill the «Batch description» field and click on «Save description» 13. Click on Manage -> Card Batches 14. Click on Export button 15. repeat step 6 and 7 --> notice the cards are now ordered. 16. Select a batch to export and click on «Export selected batches» button 17. repeat step 6 and 7 --> notice the cards are now ordered.
(In reply to Katrin Fischer from comment #5) > 3) This should also be available when printing the patron cards from the > patron card creator. Since the code for sorting is in > patroncards/create-pdf.pl, I believe this would not require much more than a > template change and it would give us nice consistency. I added the feature when printing the patron cards from the patron card creator but it required some edit in patroncards/create-pdf.pl because the order_by was only used for patronlist > > 4) I think that if you change nothing the order will still be the order > added ot the list - is this correct? (just a question, nothing to fix here) Yes it is correct, if we do not select an order, the order added at the list will be used
Created attachment 170882 [details] [review] Bug 32742: Patron's lists option are not in alphabetical order This patch add sorting feature to the patron card lists export option To test 1. Go to Tools > Patron lists 2. Create a new patron list 3. Add 10 patrons in a random order (not in alphabetical nor in cardnumber sequence) 4. Go back to Tools > Patron lists management page 5. Find your list, click on 'Action' and select 'Print patron cards' 6. Check the cards order in the pdf --> notice these cards aren't in alphabetical order. 7. Apply the patch 8. Repeat step 4, 5 9. Fill the «Order by» field and submit 10. Check the cards order in the pdf --> notice the cards are now ordered. Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Created attachment 170883 [details] [review] Bug 32742: (follow-up) Add sorting feature when printing the patron cards from the patron card creator This patch also put the «Order by» field at the last position in the form To test 1. Go to Tools > Patron card creator 2. Create a new Card batch 3. Add some patrons 4. Select all cards by clicking on checkbox in the select colunm 5. Click on «Export selected card(s)», an Export patron cards windows is opened 6. Fill the «Order by» field and submit 7. Check the cards order in the pdf --> notice the cards are now ordered. 8. Close the window opened in step 5 9. Click on «Export card batch», an Export patron cards windows is opened 10. repeat step 6 and 7 --> notice the cards are now ordered. 11. Close the window opened in step 9 12. Fill the «Batch description» field and click on «Save description» 13. Click on Manage -> Card Batches 14. Click on Export button 15. repeat step 6 and 7 --> notice the cards are now ordered. 16. Select a batch to export and click on «Export selected batches» button 17. repeat step 6 and 7 --> notice the cards are now ordered.
Created attachment 170884 [details] [review] Bug 32742: (follow-up) perltidy patroncards/create-pdf.pl and patroncards/print.pl
Created attachment 170916 [details] [review] Bug 32742: Patron's lists option are not in alphabetical order This patch add sorting feature to the patron card lists export option To test 1. Go to Tools > Patron lists 2. Create a new patron list 3. Add 10 patrons in a random order (not in alphabetical nor in cardnumber sequence) 4. Go back to Tools > Patron lists management page 5. Find your list, click on 'Action' and select 'Print patron cards' 6. Check the cards order in the pdf --> notice these cards aren't in alphabetical order. 7. Apply the patch 8. Repeat step 4, 5 9. Fill the «Order by» field and submit 10. Check the cards order in the pdf --> notice the cards are now ordered. Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Kelly <kelly@bwatersolutions.com>
Created attachment 170917 [details] [review] Bug 32742: (follow-up) Add sorting feature when printing the patron cards from the patron card creator This patch also put the «Order by» field at the last position in the form To test 1. Go to Tools > Patron card creator 2. Create a new Card batch 3. Add some patrons 4. Select all cards by clicking on checkbox in the select colunm 5. Click on «Export selected card(s)», an Export patron cards windows is opened 6. Fill the «Order by» field and submit 7. Check the cards order in the pdf --> notice the cards are now ordered. 8. Close the window opened in step 5 9. Click on «Export card batch», an Export patron cards windows is opened 10. repeat step 6 and 7 --> notice the cards are now ordered. 11. Close the window opened in step 9 12. Fill the «Batch description» field and click on «Save description» 13. Click on Manage -> Card Batches 14. Click on Export button 15. repeat step 6 and 7 --> notice the cards are now ordered. 16. Select a batch to export and click on «Export selected batches» button 17. repeat step 6 and 7 --> notice the cards are now ordered. Signed-off-by: Kelly <kelly@bwatersolutions.com>
Created attachment 170918 [details] [review] Bug 32742: (follow-up) perltidy patroncards/create-pdf.pl and patroncards/print.pl Signed-off-by: Kelly <kelly@bwatersolutions.com>
Created attachment 176400 [details] [review] Bug 32742: Patron's lists option are not in alphabetical order This patch add sorting feature to the patron card lists export option To test 1. Go to Tools > Patron lists 2. Create a new patron list 3. Add 10 patrons in a random order (not in alphabetical nor in cardnumber sequence) 4. Go back to Tools > Patron lists management page 5. Find your list, click on 'Action' and select 'Print patron cards' 6. Check the cards order in the pdf --> notice these cards aren't in alphabetical order. 7. Apply the patch 8. Repeat step 4, 5 9. Fill the «Order by» field and submit 10. Check the cards order in the pdf --> notice the cards are now ordered. Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Kelly <kelly@bwatersolutions.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Created attachment 176401 [details] [review] Bug 32742: (follow-up) Add sorting feature when printing the patron cards from the patron card creator This patch also put the «Order by» field at the last position in the form To test 1. Go to Tools > Patron card creator 2. Create a new Card batch 3. Add some patrons 4. Select all cards by clicking on checkbox in the select colunm 5. Click on «Export selected card(s)», an Export patron cards windows is opened 6. Fill the «Order by» field and submit 7. Check the cards order in the pdf --> notice the cards are now ordered. 8. Close the window opened in step 5 9. Click on «Export card batch», an Export patron cards windows is opened 10. repeat step 6 and 7 --> notice the cards are now ordered. 11. Close the window opened in step 9 12. Fill the «Batch description» field and click on «Save description» 13. Click on Manage -> Card Batches 14. Click on Export button 15. repeat step 6 and 7 --> notice the cards are now ordered. 16. Select a batch to export and click on «Export selected batches» button 17. repeat step 6 and 7 --> notice the cards are now ordered. Signed-off-by: Kelly <kelly@bwatersolutions.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Created attachment 176402 [details] [review] Bug 32742: (follow-up) perltidy patroncards/create-pdf.pl and patroncards/print.pl Signed-off-by: Kelly <kelly@bwatersolutions.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>