Bug 32757 - "Save changes" button on housebound tab should be yellow
Summary: "Save changes" button on housebound tab should be yellow
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks: 31947
  Show dependency treegraph
 
Reported: 2023-01-30 22:09 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32757: Make 'Save changes' button on housebound details yellow (1.47 KB, patch)
2023-02-09 20:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32757: Make 'Save changes' button on housebound details yellow (1.55 KB, patch)
2023-02-10 09:08 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 32757: Make 'Save changes' button on housebound details yellow (1.59 KB, patch)
2023-02-17 15:50 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-01-30 22:09:45 UTC
The button "Save changes" should be yellow on the Housebound tab.

To test:
* activate Housebound module in system preferences
* go to any patron - housebound tab in staff interface
* edit setting, verify save button is white
Comment 1 Katrin Fischer 2023-02-09 20:53:00 UTC
Created attachment 146451 [details] [review]
Bug 32757: Make 'Save changes' button on housebound details yellow

This changes the button to btn-primary to make it appear yellow.

To test:
* Enable HouseboundModule
* Search for any patron
* Go to their patron account
* Switch to Housebound tab
* Edit details
* Verify 'Save changes' is not yellow
* Apply patch
* Verify the button has changed
Comment 2 Matt Blenkinsop 2023-02-10 09:08:04 UTC
Created attachment 146463 [details] [review]
Bug 32757: Make 'Save changes' button on housebound details yellow

This changes the button to btn-primary to make it appear yellow.

To test:
* Enable HouseboundModule
* Search for any patron
* Go to their patron account
* Switch to Housebound tab
* Edit details
* Verify 'Save changes' is not yellow
* Apply patch
* Verify the button has changed

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Kyle M Hall 2023-02-17 15:50:15 UTC
Created attachment 146856 [details] [review]
Bug 32757: Make 'Save changes' button on housebound details yellow

This changes the button to btn-primary to make it appear yellow.

To test:
* Enable HouseboundModule
* Search for any patron
* Go to their patron account
* Switch to Housebound tab
* Edit details
* Verify 'Save changes' is not yellow
* Apply patch
* Verify the button has changed

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2023-02-20 12:54:57 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-02-24 08:31:40 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 6 Lucas Gass 2023-03-01 14:52:29 UTC
Not needed in 22.05.x, no backport.