When you're on the Patron restrictions administration page, the search bar at the top of the page is set to search for patron categories. Not sure if this was intentional or not, but it doesn't make sense to me. Most other administration pages (those that don't have specific searches) are set by default on system preferences search.
Created attachment 146010 [details] [review] Bug 32787: Patron restrictions admin page has patron categories search bar This patch updates the patron restriction administration page to correct the markup around the header and breadcrumbs: Using the header WRAPPER, using the sub-header WRAPPER, and switching to the system preferences search bar. The patch also corrects the page title to prevent a leading "rsaquo;" in some cases. Note: This patch contains indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Patron restrictions. The system preferences search should be preselected in the header search bar, and everything should look correct.
Created attachment 146012 [details] [review] Bug 32787: Patron restrictions admin page has patron categories search bar This patch updates the patron restriction administration page to correct the markup around the header and breadcrumbs: Using the header WRAPPER, using the sub-header WRAPPER, and switching to the system preferences search bar. The patch also corrects the page title to prevent a leading "rsaquo;" in some cases. Note: This patch contains indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Patron restrictions. The system preferences search should be preselected in the header search bar, and everything should look correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Owen!
Created attachment 146067 [details] [review] Bug 32787: Patron restrictions admin page has patron categories search bar This patch updates the patron restriction administration page to correct the markup around the header and breadcrumbs: Using the header WRAPPER, using the sub-header WRAPPER, and switching to the system preferences search bar. The patch also corrects the page title to prevent a leading "rsaquo;" in some cases. Note: This patch contains indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Patron restrictions. The system preferences search should be preselected in the header search bar, and everything should look correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Missing dependencies for 22.05.x, no backport