Bug 32787 - Patron restrictions admin page has patron categories search bar
Summary: Patron restrictions admin page has patron categories search bar
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 23681
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-01 20:10 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32787: Patron restrictions admin page has patron categories search bar (5.03 KB, patch)
2023-02-02 14:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32787: Patron restrictions admin page has patron categories search bar (5.10 KB, patch)
2023-02-02 15:08 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 32787: Patron restrictions admin page has patron categories search bar (5.19 KB, patch)
2023-02-03 10:41 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-02-01 20:10:33 UTC
When you're on the Patron restrictions administration page, the search bar at the top of the page is set to search for patron categories.

Not sure if this was intentional or not, but it doesn't make sense to me.

Most other administration pages (those that don't have specific searches) are set by default on system preferences search.
Comment 1 Owen Leonard 2023-02-02 14:56:30 UTC
Created attachment 146010 [details] [review]
Bug 32787: Patron restrictions admin page has patron categories search bar

This patch updates the patron restriction administration page to correct
the markup around the header and breadcrumbs: Using the header WRAPPER,
using the sub-header WRAPPER, and switching to the system preferences
search bar.

The patch also corrects the page title to prevent a leading "rsaquo;"
in some cases.

Note: This patch contains indentation changes, so ignore whitespace when
viewing the diff.

To test, apply the patch and go to Administration -> Patron
restrictions. The system preferences search should be preselected in the
header search bar, and everything should look correct.
Comment 2 Caroline Cyr La Rose 2023-02-02 15:08:42 UTC
Created attachment 146012 [details] [review]
Bug 32787: Patron restrictions admin page has patron categories search bar

This patch updates the patron restriction administration page to correct
the markup around the header and breadcrumbs: Using the header WRAPPER,
using the sub-header WRAPPER, and switching to the system preferences
search bar.

The patch also corrects the page title to prevent a leading "rsaquo;"
in some cases.

Note: This patch contains indentation changes, so ignore whitespace when
viewing the diff.

To test, apply the patch and go to Administration -> Patron
restrictions. The system preferences search should be preselected in the
header search bar, and everything should look correct.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Caroline Cyr La Rose 2023-02-02 15:09:00 UTC
Thanks Owen!
Comment 4 Marcel de Rooy 2023-02-03 10:41:15 UTC
Created attachment 146067 [details] [review]
Bug 32787: Patron restrictions admin page has patron categories search bar

This patch updates the patron restriction administration page to correct
the markup around the header and breadcrumbs: Using the header WRAPPER,
using the sub-header WRAPPER, and switching to the system preferences
search bar.

The patch also corrects the page title to prevent a leading "rsaquo;"
in some cases.

Note: This patch contains indentation changes, so ignore whitespace when
viewing the diff.

To test, apply the patch and go to Administration -> Patron
restrictions. The system preferences search should be preselected in the
header search bar, and everything should look correct.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi 2023-02-06 21:36:36 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-02-07 15:18:39 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-02-14 22:21:12 UTC
Missing dependencies for 22.05.x, no backport