Bug 32877 - Clean up cataloguing/value_builder/upload.pl
Summary: Clean up cataloguing/value_builder/upload.pl
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Julian Maurice
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 30975
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-03 14:13 UTC by Julian Maurice
Modified: 2025-04-14 06:52 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 32877: Fix cataloguing/value_builder/upload.pl (980 bytes, patch)
2023-02-03 14:14 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32877: Fix cataloguing/value_builder/upload.pl (1.01 KB, patch)
2023-02-04 00:01 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 32877: Fix cataloguing/value_builder/upload.pl (1.11 KB, patch)
2025-04-11 08:34 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 14:13:31 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 14:14:05 UTC
Created attachment 146144 [details] [review]
Bug 32877: Fix cataloguing/value_builder/upload.pl

Remove unnecessary call to event.preventDefault

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Lucas Gass (lukeg) 2023-02-04 00:01:38 UTC
Created attachment 146174 [details] [review]
Bug 32877: Fix cataloguing/value_builder/upload.pl

Remove unnecessary call to event.preventDefault

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Julian Maurice 2023-02-06 15:51:33 UTC
This one is actually only a cleanup patch that is not needed for bug 30975, but bug 30975 is needed for the cleanup to be possible.
Comment 4 Marcel de Rooy 2023-03-24 09:11:36 UTC
Please change status if the dependency comes into the picture ;)
Comment 5 Julian Maurice 2025-04-02 14:03:36 UTC
Changing bug status as its dependency was pushed into main
Comment 6 Marcel de Rooy 2025-04-11 08:34:58 UTC
Created attachment 180816 [details] [review]
Bug 32877: Fix cataloguing/value_builder/upload.pl

Remove unnecessary call to event.preventDefault

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Katrin Fischer 2025-04-14 06:52:11 UTC
Pushed for 25.05!

Well done everyone, thank you!