Bug 32956 - Use template wrapper for HTML customizations tabs
Summary: Use template wrapper for HTML customizations tabs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-13 18:58 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 32956: Use template wrapper for HTML customizations tabs (3.51 KB, patch)
2023-02-13 19:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32956: Use template wrapper for HTML customizations tabs (3.52 KB, patch)
2023-03-07 11:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32956: Use template wrapper for HTML customizations tabs (3.57 KB, patch)
2023-03-28 09:05 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 32956: Use template wrapper for HTML customizations tabs (3.63 KB, patch)
2023-04-09 11:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-13 18:58:26 UTC
Continuing the work of Bug 32571, the HTML customizations template should be updated to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2023-02-13 19:11:45 UTC
Created attachment 146597 [details] [review]
Bug 32956: Use template wrapper for HTML customizations tabs

This patch updates the HTML customizations template to replace tab
markup with the use of WRAPPERs.

- Apply the patch and go to Tools -> HTML customizations.
- Create or edit an entry.
- You should see tabs for each available language, for example
  Default, English, French.
- Test adding content to each language to confirm that the correct
  information is saved under the correct tab.
Comment 2 Owen Leonard 2023-03-07 11:26:44 UTC
Created attachment 147822 [details] [review]
Bug 32956: Use template wrapper for HTML customizations tabs

This patch updates the HTML customizations template to replace tab
markup with the use of WRAPPERs.

- Apply the patch and go to Tools -> HTML customizations.
- Create or edit an entry.
- You should see tabs for each available language, for example
  Default, English, French.
- Test adding content to each language to confirm that the correct
  information is saved under the correct tab.
Comment 3 PTFS Europe Sandboxes 2023-03-28 09:05:48 UTC
Created attachment 148795 [details] [review]
Bug 32956: Use template wrapper for HTML customizations tabs

This patch updates the HTML customizations template to replace tab
markup with the use of WRAPPERs.

- Apply the patch and go to Tools -> HTML customizations.
- Create or edit an entry.
- You should see tabs for each available language, for example
  Default, English, French.
- Test adding content to each language to confirm that the correct
  information is saved under the correct tab.

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 4 Katrin Fischer 2023-04-09 11:25:53 UTC
Created attachment 149350 [details] [review]
Bug 32956: Use template wrapper for HTML customizations tabs

This patch updates the HTML customizations template to replace tab
markup with the use of WRAPPERs.

- Apply the patch and go to Tools -> HTML customizations.
- Create or edit an entry.
- You should see tabs for each available language, for example
  Default, English, French.
- Test adding content to each language to confirm that the correct
  information is saved under the correct tab.

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-04-14 14:20:03 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-04-18 12:11:56 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-05-05 22:22:47 UTC
Missing 22.05.x dependencies. No backport.