Bug 33002 - 'Archive selected' button missing?
Summary: 'Archive selected' button missing?
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: regression
Depends on: 23991
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-17 19:14 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 33002: Restore "Archive selected" for archiving multiple suggestions (2.13 KB, patch)
2023-02-18 10:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33003: Show the vendor type on vendor detail page (2.60 KB, patch)
2023-02-18 10:28 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33002: Restore "Archive selected" for archiving multiple suggestions (2.19 KB, patch)
2023-02-18 15:13 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33002: Restore "Archive selected" for archiving multiple suggestions (2.25 KB, patch)
2023-02-20 14:25 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33002: Restore "Archive selected" for archiving multiple suggestions (2.33 KB, patch)
2023-02-21 08:33 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-02-17 19:14:57 UTC
Bug 30599 added the ability to archive multiple purchase suggestions. The option is not there anymore...?

To test:
1. Go to More > Suggestions
2. Click 'New purchase suggestion'
3. Enter a title
4. Click 'Submit your suggestion'
   --> Under the suggestions, there is a 'Delete selected' button/section. There should also be a 'Archive selected' button/section. The latter is not there anymore.

See https://koha-community.org/manual/22.05/en/html/_images/suggestionmanagement.png for reference in 22.05

I did a git grep "Archive selected" and didn't find anything...
Comment 1 Katrin Fischer 2023-02-18 09:55:07 UTC
Git bisect: The button was accidentally removed by:

Bug 23991: Move SearchSuggestion to Koha::Suggestions
Comment 2 Katrin Fischer 2023-02-18 10:06:14 UTC
Created attachment 146908 [details] [review]
Bug 33002: Restore "Archive selected" for archiving multiple suggestions

It looks like this button, added by bug 30599 was later
accidentally removed again. This is giving it a comeback.

To test:
1 - Apply patch
2 - Create some purchase suggestions
3 - Select several suggestions
4 - Click 'Archive selected'
5 - Suggestions are archived
6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived'
Comment 3 Katrin Fischer 2023-02-18 10:28:12 UTC
Created attachment 146909 [details] [review]
Bug 33003: Show the vendor type on vendor detail page

When using an authorised value VENDOR_TYPE for the
vendor type, we should show the AV description
everywhere instead of the code. It already works on
the vendor search, but not on the vendor detail page.
With this patch it will also work there.

To test:
1. Add at least one authorized value in VENDOR_TYPE
   1.1. Go to Administration > Authorized values
   1.2. Search for VENDOR_TYPE
   1.3. Click 'Add'
   1.4. Fill out the form
        - Authorized value: BOOK
        - Description: Print books
   1.5. Click 'Save'
2. Add a new vendor
   2.1. Go to Acquisitions
   2.2. Click 'New vendor'
   2.3. Fill out the form
        - Name: ABC Bookstore
        - Vendor type: Print books
   2.4. Click 'Save'
3. Go to the vendor page
   3.1. Click on the vendor name
   --> The value in "Type" is BOOK, it should be "Print books"
4. Apply patch
   4.1. Repeat test, now it should show the description
Comment 4 Owen Leonard 2023-02-18 15:13:52 UTC
Created attachment 146921 [details] [review]
Bug 33002: Restore "Archive selected" for archiving multiple suggestions

It looks like this button, added by bug 30599 was later
accidentally removed again. This is giving it a comeback.

To test:
1 - Apply patch
2 - Create some purchase suggestions
3 - Select several suggestions
4 - Click 'Archive selected'
5 - Suggestions are archived
6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Caroline Cyr La Rose 2023-02-20 14:25:41 UTC
Created attachment 146959 [details] [review]
Bug 33002: Restore "Archive selected" for archiving multiple suggestions

It looks like this button, added by bug 30599 was later
accidentally removed again. This is giving it a comeback.

To test:
1 - Apply patch
2 - Create some purchase suggestions
3 - Select several suggestions
4 - Click 'Archive selected'
5 - Suggestions are archived
6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 6 Caroline Cyr La Rose 2023-02-20 14:37:08 UTC
Thanks Katrin! I really thought I was having eye trouble with this one... hehe
Comment 7 Katrin Fischer 2023-02-20 14:42:28 UTC
It was definitely a little odd - rebase issue I guess.
Comment 8 Caroline Cyr La Rose 2023-02-20 14:53:46 UTC
To RMs - please backport this to 22.11 since it's also broken there
Comment 9 Jonathan Druart 2023-02-21 08:33:39 UTC
Created attachment 147016 [details] [review]
Bug 33002: Restore "Archive selected" for archiving multiple suggestions

It looks like this button, added by bug 30599 was later
accidentally removed again. This is giving it a comeback.

To test:
1 - Apply patch
2 - Create some purchase suggestions
3 - Select several suggestions
4 - Click 'Archive selected'
5 - Suggestions are archived
6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2023-02-21 08:34:15 UTC
Sorry about that! Thanks for the patch, Katrin!
Comment 11 Tomás Cohen Arazi 2023-02-21 12:18:40 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 12 Katrin Fischer 2023-02-21 13:47:00 UTC
(In reply to Jonathan Druart from comment #10)
> Sorry about that! Thanks for the patch, Katrin!

You are welcome. Doing a little detective work on the case of the "disappeared button" was fun :)
Comment 13 Jacob O'Mara 2023-02-24 11:33:26 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 14 Jacob O'Mara 2023-02-24 11:36:41 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 15 Lucas Gass 2023-03-01 14:54:41 UTC
Missing depedencies for 22.05.x, no backport.