Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in the various parts of the SIP server code where we are currently using Template::process directly.
Created attachment 147176 [details] [review] Bug 33043: Use process_tt in SIP modules Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in the various parts of the SIP server code where we are currently using Template::process directly. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP
Created attachment 147180 [details] [review] Bug 33043: Use process_tt in SIP modules Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in the various parts of the SIP server code where we are currently using Template::process directly. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP
The patch no longer applies 8-(.. Applying: Bug 33043: Use process_tt in SIP modules Using index info to reconstruct a base tree... M C4/SIP/ILS/Patron.pm Falling back to patching base and 3-way merge... Auto-merging C4/SIP/ILS/Patron.pm CONFLICT (content): Merge conflict in C4/SIP/ILS/Patron.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 33043: Use process_tt in SIP modules
Created attachment 150516 [details] [review] Bug 33043: Use process_tt in SIP modules Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in the various parts of the SIP server code where we are currently using Template::process directly. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP
Created attachment 150522 [details] [review] Bug 33043: Use process_tt in SIP modules Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in the various parts of the SIP server code where we are currently using Template::process directly. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. After applying the patch and dependencies, run updatedatabase (for 33039).
Created attachment 153430 [details] [review] Bug 33043: Use process_tt in SIP modules Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in the various parts of the SIP server code where we are currently using Template::process directly. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
OK C4/SIP/ILS/Item.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid OK C4/SIP/ILS/Patron.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not required in 23.05.x
No changes required to the manual.