Title tags (<title>) in templates present an especially difficult case for translators because we can't use our usual trick of wrapping text elements with <span>. This results in strings like this waiting for translation: #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:6 #, c-format msgid "" "%s %s Modify city %s New city %s › %s %s Confirm deletion of city " "› %s %s Cities › Administration › Koha " We can instead use the i18n template plugin introduced by Bug 15395 to wrap individual title tag elements like so: [% t("Modify city") | html %]
Created attachment 147465 [details] [review] Bug 33077: Improve ease of translating template title tags This patch uses the cities administration page as a proof-of-concept for using the [% t() %] construction to wrap translatable string in template <title> tags. This should result in a significant improvement in translatability. To test, apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - In fr-FR-staff-prog.po you should no longer see a reference to cities.tt line 6, "#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:6" - In fr-FR-messages.po you should see several strings which have been pulled individually from the <title> tag: - cities.tt:9, msgid "Modify city" - cities.tt:11, msgid "New city" - cities.tt:15, msgid "Confirm deletion of city" - cities.tt:19, msgid "Administration", msgid "Cities", msgid "Koha", and msgid "Administration" Translate the strings in fr-FR-messages.po and install the updated translation: perl misc/translator/translate install fr-FR Swith to the update language in the staff interface and confirm that the Cities page title is translated correctly.
Created attachment 147794 [details] [review] Bug 33077: Improve ease of translating template title tags This patch uses the cities administration page as a proof-of-concept for using the [% t() %] construction to wrap translatable string in template <title> tags. This should result in a significant improvement in translatability. To test, apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - In fr-FR-staff-prog.po you should no longer see a reference to cities.tt line 6, "#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:6" - In fr-FR-messages.po you should see several strings which have been pulled individually from the <title> tag: - cities.tt:9, msgid "Modify city" - cities.tt:11, msgid "New city" - cities.tt:15, msgid "Confirm deletion of city" - cities.tt:19, msgid "Administration", msgid "Cities", msgid "Koha", and msgid "Administration" Translate the strings in fr-FR-messages.po and install the updated translation: perl misc/translator/translate install fr-FR Swith to the update language in the staff interface and confirm that the Cities page title is translated correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Sorry for my confusion! It works well for cities! Will this also work with titles with variables in them? For example on moremember.pl the title is "Patron details for name (cardnumber)..."
Created attachment 149333 [details] [review] Bug 33077: Improve ease of translating template title tags This patch uses the cities administration page as a proof-of-concept for using the [% t() %] construction to wrap translatable string in template <title> tags. This should result in a significant improvement in translatability. To test, apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - In fr-FR-staff-prog.po you should no longer see a reference to cities.tt line 6, "#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:6" - In fr-FR-messages.po you should see several strings which have been pulled individually from the <title> tag: - cities.tt:9, msgid "Modify city" - cities.tt:11, msgid "New city" - cities.tt:15, msgid "Confirm deletion of city" - cities.tt:19, msgid "Administration", msgid "Cities", msgid "Koha", and msgid "Administration" Translate the strings in fr-FR-messages.po and install the updated translation: perl misc/translator/translate install fr-FR Swith to the update language in the staff interface and confirm that the Cities page title is translated correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.13.
applied to 21.11 for 21.11.21