Bug 33088 - background-job-progressbar.js no longer needed in batch_record_modification.tt
Summary: background-job-progressbar.js no longer needed in batch_record_modification.tt
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 22417
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-28 15:34 UTC by Jonathan Druart
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05,22.05.13,21.11.21


Attachments
Bug 33088: Remove background-job-progressbar.js in batch_record_modification.tt (1.11 KB, patch)
2023-03-18 03:12 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 33088: Remove background-job-progressbar.js in batch_record_modification.tt (1.16 KB, patch)
2023-04-08 23:41 UTC, David Nind
Details | Diff | Splinter Review
Bug 33088: Remove background-job-progressbar.js in batch_record_modification.tt (1.24 KB, patch)
2023-04-13 07:36 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-02-28 15:34:47 UTC
It must be removed from there, we don't need it since bug 22417

koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt:    [% Asset.js("js/background-job-progressbar.js") | $raw %]
Comment 1 Fridolin Somers 2023-03-18 03:12:41 UTC
Created attachment 148398 [details] [review]
Bug 33088: Remove background-job-progressbar.js in batch_record_modification.tt

It must be removed, we don't need it since bug 22417

Test plan :
Play with batch record modification and check there is no JS error
Comment 2 David Nind 2023-04-08 23:41:25 UTC
Created attachment 149335 [details] [review]
Bug 33088: Remove background-job-progressbar.js in batch_record_modification.tt

It must be removed, we don't need it since bug 22417

Test plan :
Play with batch record modification and check there is no JS error

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-04-08 23:43:26 UTC
Testing notes:

1. Ran some batch record modification jobs (used tempplate to add some text to 521$a): no JavaScript errors, everything worked as expected.

2. Hope this is sufficient.
Comment 4 Jonathan Druart 2023-04-13 07:36:14 UTC
Created attachment 149587 [details] [review]
Bug 33088: Remove background-job-progressbar.js in batch_record_modification.tt

It must be removed, we don't need it since bug 22417

Test plan :
Play with batch record modification and check there is no JS error

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-04-14 14:20:07 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-04-18 12:11:59 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-05-05 22:18:52 UTC
Backported to 22.05.x for upcoming 22.05.13
Comment 8 Arthur Suzuki 2023-05-23 12:06:55 UTC
applied to 21.11 for 21.11.21