Bug 33157 - Use template wrapper for item types administration tabs
Summary: Use template wrapper for item types administration tabs
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-07 14:30 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33157: Use template wrapper for item types administration tabs (8.02 KB, patch)
2023-03-07 14:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33157: Use template wrapper for item types administration tabs (7.21 KB, patch)
2023-03-07 14:43 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-07 14:30:11 UTC
Continuing the work of Bug 32571, the item types administration page should be updated to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2023-03-07 14:34:12 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-03-07 14:43:21 UTC
Created attachment 147845 [details] [review]
Bug 33157: Use template wrapper for item types administration tabs

This patch updates the item types administration template so that it
uses the new WRAPPER directive to build tabbed navigation.

To test, apply the patch and go to Administration -> Item types.

- Edit an item type.
- On the edit page you should see tabs under "Choose an icon."
- Confirm that the tabs look correct and work correctly.
- If you did not previously have any icon selected, the "None" tab
  should be active.
- If you had an icon selected, that icon set's tab should be active.
- Confirm that if you specify a remote image
  (e.g.https://via.placeholder.com/50/FF0000/FFFFFF.png) the tab is
  correctly shown after you save and re-edit.
- Confirm that changing icons works correctly and that the selected
  icon's tab is always active when you return to the edit view.
Comment 3 Owen Leonard 2023-03-07 15:30:24 UTC
There is a better way to do this...