Bug 33171 - Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder
Summary: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Martin Renvoize
URL:
Keywords:
: 24334 (view as bug list)
Depends on: 33170
Blocks: 35026
  Show dependency treegraph
 
Reported: 2023-03-08 16:17 UTC by Kyle M Hall
Modified: 2024-01-06 10:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder (7.49 KB, patch)
2023-03-08 16:18 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder (7.82 KB, patch)
2023-03-08 16:20 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder (7.81 KB, patch)
2023-07-10 18:42 UTC, Kyle M Hall
Details | Diff | Splinter Review
Marc file with mappings (4.87 KB, application/xml)
2023-11-29 11:33 UTC, Matt Blenkinsop
Details
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder (7.89 KB, patch)
2023-11-29 11:34 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder (2.16 KB, patch)
2023-11-29 11:34 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder (7.94 KB, patch)
2023-12-01 09:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder (5.91 KB, patch)
2023-12-01 09:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder (8.25 KB, patch)
2024-01-03 12:29 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder (5.91 KB, patch)
2024-01-03 12:29 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2023-03-08 16:17:41 UTC
Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference:
* coded_location_qualifier
* barcode
* enumchron
Comment 1 Kyle M Hall 2023-03-08 16:18:48 UTC
Created attachment 147964 [details] [review]
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder
Comment 2 Kyle M Hall 2023-03-08 16:20:05 UTC
Created attachment 147966 [details] [review]
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder

Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference:
* coded_location_qualifier
* barcode
* enumchron

Test Plan:
1) Set up MarcItemFieldsToOrder, verify it is functioning
2) Test coded_location_qualifier, barcode, and enumchron
3) Note the fields are imported and set for the items
Comment 3 Andrew Fuerste-Henry 2023-05-22 15:58:13 UTC
Don't forget to add these fields to the list of supported values in the syspref description, please.
Comment 4 Andrew Fuerste-Henry 2023-05-23 13:59:07 UTC
Tested this on a sandbox with the following in MarcItemFieldsToOrder:
itype: 975$y
coded_location_qualifier: 975$a
barcode: 975$b
enumchrom: 975$c

My staged record contained:
975			_y CF
_a coded location
_b barcode
_c enumchron

On addorderiso2709.pl, when creating an order from my MARC record, the itype and coded location qualifier and correctly populated, but the barcode and enumchron are not.
Comment 5 Kyle M Hall 2023-07-10 18:42:42 UTC
Created attachment 153294 [details] [review]
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder

Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference:
* coded_location_qualifier
* barcode
* enumchron

Test Plan:
1) Set up MarcItemFieldsToOrder, verify it is functioning
2) Test coded_location_qualifier, barcode, and enumchron
3) Note the fields are imported and set for the items
Comment 6 Kyle M Hall 2023-07-10 18:43:53 UTC
Fixed!

(In reply to Andrew Fuerste-Henry from comment #4)
> Tested this on a sandbox with the following in MarcItemFieldsToOrder:
> itype: 975$y
> coded_location_qualifier: 975$a
> barcode: 975$b
> enumchrom: 975$c

^ I don't know if this was wrong in your syspref, but enumchron is spelled wrong here. I caught that during testing 😁
Comment 7 Matt Blenkinsop 2023-11-29 11:33:16 UTC
Created attachment 159331 [details]
Marc file with mappings
Comment 8 Matt Blenkinsop 2023-11-29 11:34:15 UTC
Created attachment 159332 [details] [review]
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder

Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference:
* coded_location_qualifier
* barcode
* enumchron

Test Plan:
1) Set up MarcItemFieldsToOrder, verify it is functioning
2) Test coded_location_qualifier, barcode, and enumchron
3) Note the fields are imported and set for the items

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 9 Matt Blenkinsop 2023-11-29 11:34:17 UTC
Created attachment 159333 [details] [review]
Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder

This patch fixes an issue where the price is not passed to the UI when read from MarcItemFieldsToOrder.

Test plan:
1) In Administration, copy and paste the following into MarcItemFieldsToOrder:
quantity: 975$q
budget_code: 975$h
price: 975$p
itype: 975$y
coded_location_qualifier: 975$a
barcode: 975$b
enumchron: 975$c
2) Save
3) Navigate to Acquisitions and find a basket
4) Click Add to basket and select From a new file
5) Choose the file attached to this bug
6) Upload file and click Stage for import
7) Click Add staged files to basket once the job is finished
8) Check the box next to the record
9) The price should show 10.00 under Item record 1
10) coded location qualifier, barcode, enumchron should also have values as per the other commit on this bug
11) Save and import, the basket should not have a value of 0 as the price has been read correctly
12) Check the database, the newest item should have values for price, coded_location_qualifier, barcode and enumchron

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 10 Martin Renvoize 2023-12-01 09:25:48 UTC
Created attachment 159429 [details] [review]
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder

Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference:
* coded_location_qualifier
* barcode
* enumchron

Test Plan:
1) Set up MarcItemFieldsToOrder, verify it is functioning
2) Test coded_location_qualifier, barcode, and enumchron
3) Note the fields are imported and set for the items

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 11 Martin Renvoize 2023-12-01 09:25:51 UTC
Created attachment 159430 [details] [review]
Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder

This patch fixes an issue where the price is not passed to the UI when read from MarcItemFieldsToOrder.

Test plan:
1) In Administration, copy and paste the following into MarcItemFieldsToOrder:
quantity: 975$q
budget_code: 975$h
price: 975$p
itype: 975$y
coded_location_qualifier: 975$a
barcode: 975$b
enumchron: 975$c
2) Save
3) Navigate to Acquisitions and find a basket
4) Click Add to basket and select From a new file
5) Choose the file attached to this bug
6) Upload file and click Stage for import
7) Click Add staged files to basket once the job is finished
8) Check the box next to the record
9) The price should show 10.00 under Item record 1
10) coded location qualifier, barcode, enumchron should also have values as per the other commit on this bug
11) Save and import, the basket should not have a value of 0 as the price has been read correctly
12) Check the database, the newest item should have values for price, coded_location_qualifier, barcode and enumchron

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 12 Martin Renvoize 2023-12-01 09:27:14 UTC
All working as desired, QA scripts happy and no regressions found.

Passing QA
Comment 13 Nick Clemens 2024-01-03 12:29:20 UTC
Created attachment 160458 [details] [review]
Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder

Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference:
* coded_location_qualifier
* barcode
* enumchron

Test Plan:
1) Set up MarcItemFieldsToOrder, verify it is functioning
2) Test coded_location_qualifier, barcode, and enumchron
3) Note the fields are imported and set for the items

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 14 Nick Clemens 2024-01-03 12:29:22 UTC
Created attachment 160459 [details] [review]
Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder

This patch fixes an issue where the price is not passed to the UI when read from MarcItemFieldsToOrder.

Test plan:
1) In Administration, copy and paste the following into MarcItemFieldsToOrder:
quantity: 975$q
budget_code: 975$h
price: 975$p
itype: 975$y
coded_location_qualifier: 975$a
barcode: 975$b
enumchron: 975$c
2) Save
3) Navigate to Acquisitions and find a basket
4) Click Add to basket and select From a new file
5) Choose the file attached to this bug
6) Upload file and click Stage for import
7) Click Add staged files to basket once the job is finished
8) Check the box next to the record
9) The price should show 10.00 under Item record 1
10) coded location qualifier, barcode, enumchron should also have values as per the other commit on this bug
11) Save and import, the basket should not have a value of 0 as the price has been read correctly
12) Check the database, the newest item should have values for price, coded_location_qualifier, barcode and enumchron

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 15 Katrin Fischer 2024-01-06 10:05:38 UTC
*** Bug 24334 has been marked as a duplicate of this bug. ***