Bug 3319 - Need a nicer error message when attempting to add a patron with no libraries defined
Summary: Need a nicer error message when attempting to add a patron with no libraries ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-10 09:01 UTC by Liz Rea
Modified: 2012-10-25 23:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (11.24 KB, patch)
2010-08-18 17:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Revised for current HEAD (11.12 KB, patch)
2011-01-11 13:40 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:09:05 UTC


---- Reported by wizzyrea@gmail.com 2009-06-10 21:01:28 ----

The add patron screen should give a message (instead of a cryptic mysql borrowernumber=0 error)  when a new koha user tries to add a patron but has no libraries defined.

Additionally, should give an error message when a user tries to add a patron but has no patron types defined.

Currently both conditions give inadequate or nonexistant errors.



---- Additional Comments From wizzyrea@gmail.com 2009-06-10 21:05:16 ----

I might suggest a workaround that includes setting the default IntranetmainUserblock preference to include instructions to work through the administration area before trying to do any work (and a pointer to how to remove the message).



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:09 UTC  ---

This bug was previously known as _bug_ 3319 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3319

Actual time not defined. Setting to 0.0

Comment 1 Owen Leonard 2010-08-18 17:56:27 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2010-12-03 15:47:26 UTC
Original patch will probably not apply cleanly anymore. A revised version of
this fix can be found here: http://gitorious.org/koha-dev/koha-dev/commits/ps-Bug-3319-members-no-branch-error-2010-08-17
Comment 3 Owen Leonard 2011-01-11 13:40:08 UTC
Created attachment 2970 [details] [review]
Revised for current HEAD
Comment 4 Chris Cormack 2011-02-03 09:23:16 UTC
Pushed please test
Comment 5 MJ Ray (software.coop) 2011-02-06 11:14:02 UTC
This bug is mentioned in:
Fix for Bug 3319 - Need error message when	adding patron and libraries are defined http://lists.koha-community.org/pipermail/koha-patches/2011-January/013571.html