When editing notice/status triggers the letter selection is too vague. For example: 1. Add a new notice in the Circulation module with a letter code of 'ABC'. Give the new notice a name of 'Overdue notice'. 2. Now to go Overdue notice/status triggers and look at the dropdown, notice 2 choices that both read 'Overdue notice'. It would help with general troubleshooting if could also see the letter_code in the dropdown.
Created attachment 148100 [details] [review] Bug 33203: Add letter_code to the letter dropdown text To test: 1. Add a new notice in the Circulation module with a letter code of 'ABC'. Give the new notice a name of 'Overdue notice'. 2. Now to go Overdue notice/status triggers and look at the dropdown, notice 2 choices that both read 'Overdue notice'. 3. Apply patch and try again. 4. The new notice should now read "Overdue notice (ABC)" and should be easy to distinguish from the original.
Created attachment 148154 [details] [review] Bug 33203: Add letter_code to the letter dropdown text To test: 1. Add a new notice in the Circulation module with a letter code of 'ABC'. Give the new notice a name of 'Overdue notice'. 2. Now to go Overdue notice/status triggers and look at the dropdown, notice 2 choices that both read 'Overdue notice'. 3. Apply patch and try again. 4. The new notice should now read "Overdue notice (ABC)" and should be easy to distinguish from the original. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described, thanks for the patch.
Created attachment 150352 [details] [review] Bug 33203: Add letter_code to the letter dropdown text To test: 1. Add a new notice in the Circulation module with a letter code of 'ABC'. Give the new notice a name of 'Overdue notice'. 2. Now to go Overdue notice/status triggers and look at the dropdown, notice 2 choices that both read 'Overdue notice'. 3. Apply patch and try again. 4. The new notice should now read "Overdue notice (ABC)" and should be easy to distinguish from the original. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Enhancement - not backporting to 22.11.x