Bug 33264 - Rental fees should show on checkout/detail pages regardless of RentalsInNoissuesCharge
Summary: Rental fees should show on checkout/detail pages regardless of RentalsInNoiss...
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P2 normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 32450
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-17 12:38 UTC by Lucas Gass (lukeg)
Modified: 2024-05-22 07:12 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 33264: Add information about both blocking/non-blocking fines/fees to blocked-fines.inc (5.16 KB, patch)
2023-10-26 18:57 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-03-17 12:38:55 UTC
To recreate:

1. Go to Administration > Item types and add a rental charge to an item type. 
2. Check out some items of that type to a patron. 
3. With RentalsInNoissuesCharge set to 'Include' you will see those rental changes on both the checkout and detail pages.
4. Set RentalsInNoissuesCharge to 'Don't include'. You will not see the rental charges.

The charges should be displayed regardless of how the sys pref is set.
Comment 1 Suzanne 2023-03-18 22:39:06 UTC
Yes, agreed! Thank you for logging this. It is very frustrating to patrons when they suddenly find out they have fees they didn't know about. 

Fines related to rentals are not displayed for patrons, unless libraries choose to restrict patrons at the max fine rate. For example, we have a $10 limit for fines and our movies are $1-2 each. If a patron checks out $15 worth of rentals, we don't want them to have to stop and pay when they hit $10, so we are not restricting that, but what we found out is that by doing that, they don't ever see any rental related fees show up at all on the self check and staff weren't even seeing it on the checkout screen. (Some JavaScript has added it as a separate fee, but not to the total fines.) They usually find out when they have 

We would very much like to see this fixed. Thank you!
Comment 2 Suzanne 2023-10-03 19:20:19 UTC
Any chance we could get some movement on this bug? It is a continued source of frustration for patrons and staff. Thanks!
Comment 3 Lucas Gass (lukeg) 2023-10-18 17:49:44 UTC
With 32450 the plan to reproduce this changes somewhat but the problem is still the same:

1. Go to Administration > Item types and add a rental charge to an item type. 
2. Check out some items of that type to a patron. 
3. Go to Debit Types -> RENT and check "Included in noissuescharge?"
3. Now you will see those rental changes on both the checkout and detail pages, checkouts are blocked
4. Go to Debit Types -> RENT and uncheck "Included in noissuescharge?"
5. Now you see no information about the rental charges on the checkout/detail pages.
Comment 4 Lucas Gass (lukeg) 2023-10-18 18:07:04 UTC
I wouldn't consider this a bug and upon further thought I don't know if showing rental changes when the patron is not blocked is necessary or even wanted. That additional information clutters up an already busy checkout/detail view. 

With a single click staff can visit the Accounting tab of a patron and get a view of all charges/fees/etc. related to the patron. My inclination here is mark this as 'resolved - won't fix'.
Comment 5 Suzanne 2023-10-19 15:52:15 UTC
Lucas, I'm not sure you remember the magnitude of this problem for our library. It's been happening on a daily basis ever since migrating last December. Here are the factors that make it a big issue.
1. We are not fee, so patrons have fines
2. We charge for rentals and renewals of videos
3. We don't want to limit our patrons in the amount of videos they check out, if their fine (which we want to include unpaid video rental fees) is not over our fine limit.
4. Our patrons check out almost exclusively on self check stations and they are not including the rental related fees in the amount shown, because they are not being sent through SIP.

The biggest problem we run into happens when a patron has unpaid renewal and/or rental fees AND they suddenly have a regular fine.
1. They try to pay their fine on the self check and think they have paid in full, but then it immediately tells them they have more fine, because it doesn't pay the new fine, it pays the older rental /renewal fees, which they don't even know about. Sometimes they pay again and the problem can happen again and again, depending on how much they owe in renewal/rental fees. 
2. Patrons complain to staff about this, saying they always pay their fees and we have to tell them they have fees they didn't know about because our self checks can't tell them about the renewal/rental fees.
3. These renewal/rental fees could be from months ago and we end up writing amounts off, because patrons are frustrated and so are we. (I realize they can see and pay the fees on Aspen, but many don't check that.)

Does that make sense why this is such a problem, to be considered a bug? We have had a ticket in since January, even offering to pay for development to get this resolved, without even getting an estimate on the cost. Please help.
Comment 6 Lucas Gass (lukeg) 2023-10-26 18:57:18 UTC
Created attachment 157947 [details] [review]
Bug 33264: Add information about both blocking/non-blocking fines/fees to blocked-fines.inc

1. Go to Administration > Item types and add a rental charge to an item type.
2. Check out some items of that type to a patron.
3. Go to Debit Types -> RENT and check "Included in noissuescharge?"
3. Now you will see those rental changes on both the checkout and detail pages, checkouts are blocked
4. Go to Debit Types -> RENT and uncheck "Included in noissuescharge?"
5. Now you see no information about the rental charges on the checkout/detail pages.
6. APPLY PATCH, restart services
7. Now check the morememember.pl and cicruclation.pl pages. You should see information about both blocking/non-blocking charges on both of the pages.
8. Turn on BatchCheckout
9. Now from the patrons batch checkout screen make sure the information appears for both blocking/non-blocking charges.
Comment 7 Lucas Gass (lukeg) 2023-10-26 19:04:13 UTC
> 4. Our patrons check out almost exclusively on self check stations and they
> are not including the rental related fees in the amount shown, because they
> are not being sent through SIP.

This patchset deals with the display in the staff interface on the moremember.pl and circulation.pl pages. Anything dealing with SIP should be a separate bug.
Comment 8 David Nind 2023-10-26 21:39:51 UTC
For Step 9, I'm not seeing the message about blocking and non-blocking fines if "Included in noissuescharge?" is not ticked.
Comment 9 Suzanne 2024-05-22 01:09:42 UTC
So, do we need to log a separate bug to get the fees to show up through SIP together? 33228 is related to this bug.

Thanks!
Suzanne
Comment 10 Katrin Fischer 2024-05-22 07:12:54 UTC
(In reply to Suzanne from comment #9)
> So, do we need to log a separate bug to get the fees to show up through SIP
> together? 33228 is related to this bug.
> 
> Thanks!
> Suzanne

Yes, SIP should be handled separately. But I think this here is just a display issue, a rental charge that has been "charged" should be visible on the patron account via SIP. But maybe there is also a different place it could show? Please file a new bug.