When using Claim Return, if an item has already been charged as Long Overdue (lost) it does not get refunded when a claim is made, even if lost item fee refund on return policy is set to "Refund" and MarkLostItemsAsReturned includes "When marking an item as a return claim" Since the library is not actually checking the item in it doesn't refund automatically. The library could check the item in and not resolve the claim, but that's an extra step and may not work with all workflows. Having the option to refund the lost fee on claim would be helpful for many libraries.
"Having the option to refund the lost fee on claim would be helpful for many libraries." I agree with Lisette, ALL of our libraries would appreciate this. +1
I still agree with Lisette.
I have written a patch for this bug but I'm holding off submitting it until a way forward is agreed for bug 27919, currently awaiting QA
Created attachment 171966 [details] [review] Bug 33292: Add a checkbox to refund a lost fee on return claim
Created attachment 171967 [details] [review] Bug 33292: Add logic to handle refunding a lost fee This patch allows the return claims endpoint to handle the refunding of a lost fee for the item if the checkbox is checked
Created attachment 171968 [details] [review] Bug 33292: Add unit tests Test plan: 1) In KTD, set ClaimReturnedLostValue to any value 2) Checkout an item to a patron 3) Add a manual invoice to that patron's account against that item barcode 4) In the patron's checkouts table, click the Claim returned button 5) The checkbox will have the option to "Refund previous lost fee" 6) Tick this box and submit 7) Have a look at the patron's transactions. There will now be a new line refunding the lost fee from step 3 8) Run the unit tests prove t/db_dependent/Circulation/ReturnClaims.t prove t/db_dependent/api/v1/return_claims.t
Do you happen to have any partners keen to test this for us Lisette?
If this can be done in a sandbox rather than KTD, I could give it a try.
Steps 1 - 7 should be fine to run in a sandbox (sandboxes are generally just KTD instances)
What would happen with step 8 then?
That could be covered at QA stage or we can ask someone to add another sign-off line for the tests. If you're happy to do steps 1 - 7 it would be good to prove the concept works :)
Created attachment 172269 [details] [review] Bug 33292: Add unit tests Test plan: 1) In KTD, set ClaimReturnedLostValue to any value 2) Checkout an item to a patron 3) Add a manual invoice to that patron's account against that item barcode 4) In the patron's checkouts table, click the Claim returned button 5) The checkbox will have the option to "Refund previous lost fee" 6) Tick this box and submit 7) Have a look at the patron's transactions. There will now be a new line refunding the lost fee from step 3 8) Run the unit tests prove t/db_dependent/Circulation/ReturnClaims.t prove t/db_dependent/api/v1/return_claims.t Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org>
Test plan: 1) In KTD, set ClaimReturnedLostValue to any value -- I Used 'Lost' 2) Checkout an item to a patron -- I used 39999000012392 3) Add a manual invoice to that patron's account against that item barcode I used patron with card number 23529000318858 and added a 1.50 charge. 4) In the patron's checkouts table, click the Claim returned button 5) The checkbox will have the option to "Refund previous lost fee" 6) Tick this box and submit 7) Have a look at the patron's transactions. There will now be a new line refunding the lost fee from step 3 This all worked as expected. Screenshots of the "refund previous lost fee" popup and the account lines will be attached.
Created attachment 172270 [details] Popup Refund Fee Shows popup window for refund previous lost fee option on claims return.
Created attachment 172271 [details] Account Lines Claims Return Refund Shows the account line added when fee is refunded on claims return.
Created attachment 172673 [details] [review] Bug 33292: Add a checkbox to refund a lost fee on return claim Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 172674 [details] [review] Bug 33292: Add logic to handle refunding a lost fee This patch allows the return claims endpoint to handle the refunding of a lost fee for the item if the checkbox is checked Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 172675 [details] [review] Bug 33292: Add unit tests Test plan: 1) In KTD, set ClaimReturnedLostValue to any value 2) Checkout an item to a patron 3) Add a manual invoice to that patron's account against that item barcode 4) In the patron's checkouts table, click the Claim returned button 5) The checkbox will have the option to "Refund previous lost fee" 6) Tick this box and submit 7) Have a look at the patron's transactions. There will now be a new line refunding the lost fee from step 3 8) Run the unit tests prove t/db_dependent/Circulation/ReturnClaims.t prove t/db_dependent/api/v1/return_claims.t Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>