Bug 33320 - Patron modification requests: options are squashed
Summary: Patron modification requests: options are squashed
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
: 33520 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-23 10:52 UTC by Katrin Fischer
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33320: Add spacing in Patron modification requests (1.79 KB, patch)
2023-05-11 10:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33320: Add spacing in Patron modification requests (1.84 KB, patch)
2023-05-11 11:13 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33320: Add spacing in Patron modification requests (1.93 KB, patch)
2023-05-11 13:37 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-03-23 10:52:13 UTC
To test:
* Go to the OPAC, log into your account
* Make changes to your personal details and save
* Go to the staff interface and use the link on the start page to moderate the change request
* At the top of the list you'll see something like:
  Ignore|Patron details

We are missing spaces after Ignore and before Patron details.
Comment 1 Jonathan Druart 2023-05-11 10:52:36 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-05-11 11:13:50 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2023-05-11 13:37:48 UTC
Created attachment 151080 [details] [review]
Bug 33320: Add spacing in Patron modification requests

* Go to the OPAC, log into your account
* Make changes to your personal details and save
* Go to the staff interface and use the link on the start page to
  moderate the change request
* At the top of the list you'll see something like:

Without this patch:
  Ignore|Patron details
With this patch:
  Ignore | Patron details

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2023-05-12 14:21:12 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-05-15 13:00:33 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Owen Leonard 2023-06-02 13:27:22 UTC
*** Bug 33520 has been marked as a duplicate of this bug. ***