Bug 33325 - UpdateItemLocationOnCheckin message should accurately report when location set to null
Summary: UpdateItemLocationOnCheckin message should accurately report when location se...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-23 16:50 UTC by Andrew Fuerste-Henry
Modified: 2023-03-23 16:50 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2023-03-23 16:50:36 UTC 
To recreate:
1 - set UpdateItemLocationOnCheckin to "_ALL_: _PERM_"
2 - have an item where items.permanent_location is null but items.location is not null
3 - check your item in, get message that location was updated, including wording "New value: "Blank""
4 - check your item in the database, confirm location has been set to NULL rather than blank

Getting location to have a value with permanent_location is null takes some niche setup to accomplish in the staff interface. See this comment for instructions, but it'd be easier to just set up a test item from the database:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33301#c2

The UpdateItemLocationOnCheckin syspref contains the option to set things to "_BLANK_" at checkin. When that option is used, things are actually set to blank (items.location='') rather than NULL, so in those cases the message *is* accurate.