Created attachment 148885 [details] [review] Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd
Created attachment 148886 [details] [review] Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns
Created attachment 148887 [details] [review] Bug 33355: Tidyness for forms markup, squash this later
Created attachment 148888 [details] [review] Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content
Cypress tests are happy
Created attachment 148934 [details] [review] Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd
Created attachment 148935 [details] [review] Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns
Created attachment 148936 [details] [review] Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content
Created attachment 149116 [details] [review] Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 149117 [details] [review] Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 149118 [details] [review] Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
*** Bug 33542 has been marked as a duplicate of this bug. ***
It would help to have a test plan to know what is supposed to be corrected. I came here because of the 'is perpetual' thing, but I'm not sure what the other commits do
Created attachment 149760 [details] Screenshot before patch 149117 and the problems it fixes
Created attachment 149761 [details] Screenshot before patch 149118 and the problems it fixes
(In reply to Caroline Cyr La Rose from comment #13) > It would help to have a test plan to know what is supposed to be corrected. > I came here because of the 'is perpetual' thing, but I'm not sure what the > other commits do Hi Caroline, thank you so much for looking into this. Apologies for not being clear enough. Please take a look at the screenshots I attached, I hope those help in explaining the problems and respective fixes.
Created attachment 149883 [details] [review] Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 149884 [details] [review] Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 149885 [details] [review] Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Something in me doesn't really like the fieldset nesting this introduces.. but display wise it's working well. Code is all working after the changes, Passing QA
Created attachment 150043 [details] [review] Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 150044 [details] [review] Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 150045 [details] [review] Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 150163 [details] [review] Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 150164 [details] [review] Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 150165 [details] [review] Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Please rebase ASAP.
Created attachment 150759 [details] [review] Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 150760 [details] [review] Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 150761 [details] [review] Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Missing dependencies for 22.05.x, no backport