Bug 33360 - SendQueuedMessages: Improve limit behavior and add domain limits
Summary: SendQueuedMessages: Improve limit behavior and add domain limits
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33537
  Show dependency tree / graph
 
Reported: 2023-03-29 15:01 UTC by Marcel de Rooy
Modified: 2024-07-25 11:15 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
In order to control/throttle the volume of mail messages sent by Koha, this report makes the limit parameter of process_message_queue (and associated routine in Letters) look at the number of messages actually sent, not processed. It also adds the possibility of delaying messages to specified domains according to limits defined in koha-conf.xml (see example section added in this patch set). For instance, you may define that each minute only 30 messages are sent to outlook.com or 50 messages per hour to gmail.com, etc. This will help in reducing deferred or rejected mails due to exceeding limits of various email providers.
Version(s) released in:
23.05.00
Circulation function:

Attachments
Bug 33360: Add Koha::Notice::Util for mail domain limits (9.79 KB, patch)
2023-04-07 09:33 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33360: Extend Koha::Notice::Util with domain groups (10.73 KB, patch)
2023-04-07 09:33 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages (1.68 KB, patch)
2023-04-07 09:33 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33360: Add Koha::Notice::Util for mail domain limits (9.82 KB, patch)
2023-04-12 13:45 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33360: Extend Koha::Notice::Util with domain groups (11.02 KB, patch)
2023-04-12 13:45 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages (2.33 KB, patch)
2023-04-12 13:45 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33360: Improving limit behavior in SendQueuedMessages (9.56 KB, patch)
2023-04-12 13:45 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33360: Adjust Letters.t for limit parameter and domain limits (9.93 KB, patch)
2023-04-12 13:45 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33360: Update koha-conf.xml (2.25 KB, patch)
2023-04-12 13:45 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33360: (follow-up) Adjust wording in verbose mode (1.24 KB, patch)
2023-04-12 13:45 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33360: Add Koha::Notice::Util for mail domain limits (9.84 KB, patch)
2023-04-14 09:05 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33360: Extend Koha::Notice::Util with domain groups (11.04 KB, patch)
2023-04-14 09:05 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages (2.35 KB, patch)
2023-04-14 09:05 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33360: Improving limit behavior in SendQueuedMessages (9.58 KB, patch)
2023-04-14 09:05 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33360: Adjust Letters.t for limit parameter and domain limits (9.95 KB, patch)
2023-04-14 09:05 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33360: Update koha-conf.xml (2.28 KB, patch)
2023-04-14 09:06 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33360: (follow-up) Adjust wording in verbose mode (1.27 KB, patch)
2023-04-14 09:06 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33360: Add Koha::Notice::Util for mail domain limits (9.90 KB, patch)
2023-04-14 10:59 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 33360: Extend Koha::Notice::Util with domain groups (11.10 KB, patch)
2023-04-14 10:59 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages (2.41 KB, patch)
2023-04-14 10:59 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 33360: Improving limit behavior in SendQueuedMessages (9.64 KB, patch)
2023-04-14 11:00 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 33360: Adjust Letters.t for limit parameter and domain limits (10.01 KB, patch)
2023-04-14 11:00 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 33360: Update koha-conf.xml (2.34 KB, patch)
2023-04-14 11:00 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 33360: (follow-up) Adjust wording in verbose mode (1.32 KB, patch)
2023-04-14 11:00 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (17) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-03-29 15:01:24 UTC 
Some email providers look at rates per minute, or day, etc. for sending or receiving mail. E.g. Gmail does not like incidental bursts.
Our current limit parameter does just look at the total volume but could perhaps be made smarter than that?
Comment 1 Marcel de Rooy 2023-04-07 09:33:09 UTC 
Created attachment 149256 [details] [review]
Bug 33360: Add Koha::Notice::Util for mail domain limits

Includes unit test.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-04-07 09:33:12 UTC 
Created attachment 149257 [details] [review]
Bug 33360: Extend Koha::Notice::Util with domain groups
Comment 3 Marcel de Rooy 2023-04-07 09:33:14 UTC 
Created attachment 149258 [details] [review]
Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages
Comment 4 Marcel de Rooy 2023-04-07 09:36:24 UTC 
This is still work in progess.
I stumbled over the where parameter now while converting stuff to a Koha object search. Not sure if we resolved such a thing somewhere else already.
Could we automatically convert an old school SQL WHERE condition to correct Koha object/DBIx conditions?
Comment 5 Marcel de Rooy 2023-04-07 09:46:40 UTC 
<Joubu> marcelr: 33360 - see misc/cronjobs/membership_expiry.pl:199 $upcoming_mem_expires = $upcoming_mem_expires->search( \$where_literal ) if @where;
Comment 6 Marcel de Rooy 2023-04-07 10:02:00 UTC 
(In reply to Marcel de Rooy from comment #5)
> <Joubu> marcelr: 33360 - see misc/cronjobs/membership_expiry.pl:199
> $upcoming_mem_expires = $upcoming_mem_expires->search( \$where_literal ) if
> @where;

Yes, that would be enough!
Comment 7 Marcel de Rooy 2023-04-07 10:02:41 UTC 
Still patches forthcoming.
Comment 8 Marcel de Rooy 2023-04-12 13:45:00 UTC 
Created attachment 149546 [details] [review]
Bug 33360: Add Koha::Notice::Util for mail domain limits

Ground work in new module.
Includes unit test.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2023-04-12 13:45:02 UTC 
Created attachment 149547 [details] [review]
Bug 33360: Extend Koha::Notice::Util with domain groups

The functionality is extended a bit here by:
[1] Allowing to combine domains in a shared count.
[2] Only counting sent messages for the specified
    domains when it is really needed.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Marcel de Rooy 2023-04-12 13:45:05 UTC 
Created attachment 149548 [details] [review]
Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages

Minimal adjustment to get the feature working.
Will still be improved in follow-up.

Test plan:
[1] Add a domain limit to your koha-conf:
    <message_domain_limits>
    <domain><name>gmail.com</name><limit>1</limit> <unit>1h</unit></domain>
    </message_domain_limits>
    Replace gmail.com by the domain you want to send to.
    Restart all.
[2] Disable cron job for message queue.
[3] Generate two pending notices in the queue.
[4] Run process_message_queue.pl
[5] Check that one is sent, one is still pending.
[6] Run again.
[7] Check: nothing is sent, last one still pending.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 11 Marcel de Rooy 2023-04-12 13:45:07 UTC 
Created attachment 149549 [details] [review]
Bug 33360: Improving limit behavior in SendQueuedMessages

Includes:
[1] Do no longer use the limit in the sql selection, but apply the
limit as a maximum for the number of sent messages. This is more
practical in terms of not flooding your mail server (and the
receiving ones).

[2] Replace call of _get_unsent_messages by Koha objects search.

[3] Do no longer report the number of messages seen, but report the
number actually 'sent'.

[4] If we lookup the to_address but we need to delay a message, save
the email address for the next run. Also optimizing patron lookup
in _send_message_by_email.

[5} Add support for $where parameter in SendQueuedMessages. Used by
process_message_queue.pl.

[6] Handle scalar/array for letter_code and type parameter too.

Test plan:
[1] Adjust your domain limit settings in koha-conf.
    Use notices to three domains. Group A and B.
    <message_domain_limits>
    <domain><name>A</name><limit>1</limit><unit>1h</unit></domain>
    <domain><name>B/name><belongs_to>A</belongs_to></domain>
    <domain><name>C</name><limit>1</limit><unit>1h</unit></domain>
    </message_domain_limits>
    Replace A, B and C with your choice. Do not forget the belongs_to.
    Restart all.
[2] Disable cron job for message queue.
[3] Generate two notices for each domain A, B and C (in that order).
    Make sure that borrowers involved have correct address.
[4] Run process_message_queue.pl -limit 1
[5] Check that one is sent for A, 5 pending.
[6] Run process_message_queue.pl -limit 2
[7] Check that one is sent for C, 4 pending.
[8] Run process_message_queue.pl (without limit).
[9] Check that nothing is sent, 4 pending.
[10] Check that message_queue.to_address is filled for those 4.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 12 Marcel de Rooy 2023-04-12 13:45:09 UTC 
Created attachment 149550 [details] [review]
Bug 33360: Adjust Letters.t for limit parameter and domain limits

Includes:
[1] Add a counter in the send_or_die mock.
[2] Correct from processed count to sent count.
[3] More extensive testing for limit parameter and domain limits.

Test plan:
Run t/db_dependent/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 13 Marcel de Rooy 2023-04-12 13:45:11 UTC 
Created attachment 149551 [details] [review]
Bug 33360: Update koha-conf.xml

Test plan:
We already tested it. Just look at changes in this patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 14 Marcel de Rooy 2023-04-12 13:45:13 UTC 
Created attachment 149552 [details] [review]
Bug 33360: (follow-up) Adjust wording in verbose mode

Koha reports 'sending mail' while we actually are still
processing mail. It could still be delayed, fail, etc.

Test plan:
Run process_message_queue in verbose mode. If a message
get processed, you should see:
    Processing email message to patron: 51 at /usr/share/koha/C4/Letters.pm line 1008.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 15 Marcel de Rooy 2023-04-12 13:56:38 UTC 
Note for testers/QA: An adjusted version already runs in production on 21.11 for me. And was 'put to the test' with a large mailing already.
Comment 16 Martin Renvoize (ashimema) 2023-04-14 09:05:48 UTC 
Created attachment 149645 [details] [review]
Bug 33360: Add Koha::Notice::Util for mail domain limits

Ground work in new module.
Includes unit test.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 17 Martin Renvoize (ashimema) 2023-04-14 09:05:51 UTC 
Created attachment 149646 [details] [review]
Bug 33360: Extend Koha::Notice::Util with domain groups

The functionality is extended a bit here by:
[1] Allowing to combine domains in a shared count.
[2] Only counting sent messages for the specified
    domains when it is really needed.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 18 Martin Renvoize (ashimema) 2023-04-14 09:05:53 UTC 
Created attachment 149647 [details] [review]
Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages

Minimal adjustment to get the feature working.
Will still be improved in follow-up.

Test plan:
[1] Add a domain limit to your koha-conf:
    <message_domain_limits>
    <domain><name>gmail.com</name><limit>1</limit> <unit>1h</unit></domain>
    </message_domain_limits>
    Replace gmail.com by the domain you want to send to.
    Restart all.
[2] Disable cron job for message queue.
[3] Generate two pending notices in the queue.
[4] Run process_message_queue.pl
[5] Check that one is sent, one is still pending.
[6] Run again.
[7] Check: nothing is sent, last one still pending.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 19 Martin Renvoize (ashimema) 2023-04-14 09:05:56 UTC 
Created attachment 149648 [details] [review]
Bug 33360: Improving limit behavior in SendQueuedMessages

Includes:
[1] Do no longer use the limit in the sql selection, but apply the
limit as a maximum for the number of sent messages. This is more
practical in terms of not flooding your mail server (and the
receiving ones).

[2] Replace call of _get_unsent_messages by Koha objects search.

[3] Do no longer report the number of messages seen, but report the
number actually 'sent'.

[4] If we lookup the to_address but we need to delay a message, save
the email address for the next run. Also optimizing patron lookup
in _send_message_by_email.

[5} Add support for $where parameter in SendQueuedMessages. Used by
process_message_queue.pl.

[6] Handle scalar/array for letter_code and type parameter too.

Test plan:
[1] Adjust your domain limit settings in koha-conf.
    Use notices to three domains. Group A and B.
    <message_domain_limits>
    <domain><name>A</name><limit>1</limit><unit>1h</unit></domain>
    <domain><name>B/name><belongs_to>A</belongs_to></domain>
    <domain><name>C</name><limit>1</limit><unit>1h</unit></domain>
    </message_domain_limits>
    Replace A, B and C with your choice. Do not forget the belongs_to.
    Restart all.
[2] Disable cron job for message queue.
[3] Generate two notices for each domain A, B and C (in that order).
    Make sure that borrowers involved have correct address.
[4] Run process_message_queue.pl -limit 1
[5] Check that one is sent for A, 5 pending.
[6] Run process_message_queue.pl -limit 2
[7] Check that one is sent for C, 4 pending.
[8] Run process_message_queue.pl (without limit).
[9] Check that nothing is sent, 4 pending.
[10] Check that message_queue.to_address is filled for those 4.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 20 Martin Renvoize (ashimema) 2023-04-14 09:05:58 UTC 
Created attachment 149649 [details] [review]
Bug 33360: Adjust Letters.t for limit parameter and domain limits

Includes:
[1] Add a counter in the send_or_die mock.
[2] Correct from processed count to sent count.
[3] More extensive testing for limit parameter and domain limits.

Test plan:
Run t/db_dependent/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 21 Martin Renvoize (ashimema) 2023-04-14 09:06:01 UTC 
Created attachment 149650 [details] [review]
Bug 33360: Update koha-conf.xml

Test plan:
We already tested it. Just look at changes in this patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 22 Martin Renvoize (ashimema) 2023-04-14 09:06:03 UTC 
Created attachment 149651 [details] [review]
Bug 33360: (follow-up) Adjust wording in verbose mode

Koha reports 'sending mail' while we actually are still
processing mail. It could still be delayed, fail, etc.

Test plan:
Run process_message_queue in verbose mode. If a message
get processed, you should see:
    Processing email message to patron: 51 at /usr/share/koha/C4/Letters.pm line 1008.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 23 Marcel de Rooy 2023-04-14 09:14:35 UTC 
*** Bug 30013 has been marked as a duplicate of this bug. ***
Comment 24 Martin Renvoize (ashimema) 2023-04-14 09:19:50 UTC 
All working well in testing, not obvious code issues.

Signing Off
Comment 25 Kyle M Hall (khall) 2023-04-14 10:59:50 UTC 
Created attachment 149662 [details] [review]
Bug 33360: Add Koha::Notice::Util for mail domain limits

Ground work in new module.
Includes unit test.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 26 Kyle M Hall (khall) 2023-04-14 10:59:57 UTC 
Created attachment 149663 [details] [review]
Bug 33360: Extend Koha::Notice::Util with domain groups

The functionality is extended a bit here by:
[1] Allowing to combine domains in a shared count.
[2] Only counting sent messages for the specified
    domains when it is really needed.

Test plan:
Run t/db_dependent/Koha/Notice_Util.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 27 Kyle M Hall (khall) 2023-04-14 10:59:59 UTC 
Created attachment 149664 [details] [review]
Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages

Minimal adjustment to get the feature working.
Will still be improved in follow-up.

Test plan:
[1] Add a domain limit to your koha-conf:
    <message_domain_limits>
    <domain><name>gmail.com</name><limit>1</limit> <unit>1h</unit></domain>
    </message_domain_limits>
    Replace gmail.com by the domain you want to send to.
    Restart all.
[2] Disable cron job for message queue.
[3] Generate two pending notices in the queue.
[4] Run process_message_queue.pl
[5] Check that one is sent, one is still pending.
[6] Run again.
[7] Check: nothing is sent, last one still pending.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 28 Kyle M Hall (khall) 2023-04-14 11:00:01 UTC 
Created attachment 149665 [details] [review]
Bug 33360: Improving limit behavior in SendQueuedMessages

Includes:
[1] Do no longer use the limit in the sql selection, but apply the
limit as a maximum for the number of sent messages. This is more
practical in terms of not flooding your mail server (and the
receiving ones).

[2] Replace call of _get_unsent_messages by Koha objects search.

[3] Do no longer report the number of messages seen, but report the
number actually 'sent'.

[4] If we lookup the to_address but we need to delay a message, save
the email address for the next run. Also optimizing patron lookup
in _send_message_by_email.

[5} Add support for $where parameter in SendQueuedMessages. Used by
process_message_queue.pl.

[6] Handle scalar/array for letter_code and type parameter too.

Test plan:
[1] Adjust your domain limit settings in koha-conf.
    Use notices to three domains. Group A and B.
    <message_domain_limits>
    <domain><name>A</name><limit>1</limit><unit>1h</unit></domain>
    <domain><name>B/name><belongs_to>A</belongs_to></domain>
    <domain><name>C</name><limit>1</limit><unit>1h</unit></domain>
    </message_domain_limits>
    Replace A, B and C with your choice. Do not forget the belongs_to.
    Restart all.
[2] Disable cron job for message queue.
[3] Generate two notices for each domain A, B and C (in that order).
    Make sure that borrowers involved have correct address.
[4] Run process_message_queue.pl -limit 1
[5] Check that one is sent for A, 5 pending.
[6] Run process_message_queue.pl -limit 2
[7] Check that one is sent for C, 4 pending.
[8] Run process_message_queue.pl (without limit).
[9] Check that nothing is sent, 4 pending.
[10] Check that message_queue.to_address is filled for those 4.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 29 Kyle M Hall (khall) 2023-04-14 11:00:04 UTC 
Created attachment 149666 [details] [review]
Bug 33360: Adjust Letters.t for limit parameter and domain limits

Includes:
[1] Add a counter in the send_or_die mock.
[2] Correct from processed count to sent count.
[3] More extensive testing for limit parameter and domain limits.

Test plan:
Run t/db_dependent/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 30 Kyle M Hall (khall) 2023-04-14 11:00:06 UTC 
Created attachment 149667 [details] [review]
Bug 33360: Update koha-conf.xml

Test plan:
We already tested it. Just look at changes in this patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 31 Kyle M Hall (khall) 2023-04-14 11:00:08 UTC 
Created attachment 149668 [details] [review]
Bug 33360: (follow-up) Adjust wording in verbose mode

Koha reports 'sending mail' while we actually are still
processing mail. It could still be delayed, fail, etc.

Test plan:
Run process_message_queue in verbose mode. If a message
get processed, you should see:
    Processing email message to patron: 51 at /usr/share/koha/C4/Letters.pm line 1008.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 32 Kyle M Hall (khall) 2023-04-14 11:04:07 UTC 
QA thoughts: Considering the SMTP configuration is web based, it would be nice if the controls for this were integrated into it.
Comment 33 Marcel de Rooy 2023-04-14 11:32:21 UTC 
(In reply to Kyle M Hall from comment #32)
> QA thoughts: Considering the SMTP configuration is web based, it would be
> nice if the controls for this were integrated into it.

Thanks Kyle for QA.
Happy to put some further improvements on a follow-up.
Comment 34 Tomás Cohen Arazi (tcohen) 2023-04-14 14:17:01 UTC 
(In reply to Kyle M Hall from comment #32)
> QA thoughts: Considering the SMTP configuration is web based, it would be
> nice if the controls for this were integrated into it.

Agreed!
Comment 35 Tomás Cohen Arazi (tcohen) 2023-04-14 14:20:14 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 36 Marcel de Rooy 2023-04-14 15:09:24 UTC 
(In reply to Tomás Cohen Arazi from comment #35)
> Pushed to master for 23.05.
> 
> Nice work everyone, thanks!

Top !
Comment 37 Marcel de Rooy 2023-04-14 15:12:58 UTC 
(In reply to Tomás Cohen Arazi from comment #34)
> (In reply to Kyle M Hall from comment #32)
> > QA thoughts: Considering the SMTP configuration is web based, it would be
> > nice if the controls for this were integrated into it.
> 
> Agreed!

Bug 33537
Comment 38 Matt Blenkinsop 2023-04-18 12:10:28 UTC 
Enhancement - not backporting to 22.11.x

Nice work everyone!
Comment 39 Liz Rea 2023-06-07 20:50:10 UTC 
(In reply to Kyle M Hall from comment #32)
> QA thoughts: Considering the SMTP configuration is web based, it would be
> nice if the controls for this were integrated into it.

100% this yes please