Bug 33407 - With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results
Summary: With ES and QueryAutoTruncate on, a search containing ISBD punctuation return...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: Main
Hardware: All All
: P3 normal (vote)
Assignee: Janusz Kaczmarek
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-04 14:37 UTC by Janusz Kaczmarek
Modified: 2024-04-16 16:18 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33407: With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results (2.03 KB, patch)
2024-04-10 19:57 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 33407: Unit tests (1.42 KB, patch)
2024-04-10 19:57 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 33407: With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results (2.08 KB, patch)
2024-04-16 16:18 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 33407: Unit tests (1.47 KB, patch)
2024-04-16 16:18 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2023-04-04 14:37:49 UTC
With ES and QueryAutoTruncate on, a search with punctuation surrounded by spaces (like ISBD punctuation copied from other catalogue or bibliography) returns no results.  E.g.: in a search for "Maria Stuart ; Die Jungfrau von Orleans / Schiller" (coded in record as 245 10 $a Maria Stuart ; $b Die Jungfrau von Orleans / $c Schiller) -- both semicolon and slash cause problems.  One had to remove them manually to get results which is not what is desired.
Comment 1 Janusz Kaczmarek 2024-04-10 19:57:01 UTC
Created attachment 164633 [details] [review]
Bug 33407: With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results

With ES and QueryAutoTruncate on, a search with punctuation surrounded
by spaces (like ISBD punctuation copied from other catalogue or
bibliography) returns no results.  E.g.: in a search for "Maria Stuart ;
Die Jungfrau von Orleans / Schiller" (coded in record as 245 10 $a Maria
Stuart ; $b Die Jungfrau von Orleans / $c Schiller) -- both semicolon
and slash cause problems.  One had to remove them manually to get
results which is not what is desired.

Test plan
=========
1. Use ktd with Elasticsearch and ktd's test data
   (http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1):
2. Make a search for the first ISBD zone taken verbatim from the first record:
   E Street shuffle : the glory days of Bruce Springsteen & the E Street Band / Clinton Heylin

   There should be no result.
3. Apply teh patch, restart plack.
4. Repeat the search. You should get the record (and onother one).

Sponsored-by: Ignatianum University in Cracow
Comment 2 Janusz Kaczmarek 2024-04-10 19:57:04 UTC
Created attachment 164634 [details] [review]
Bug 33407: Unit tests
Comment 3 Roman Dolny 2024-04-16 16:18:41 UTC
Created attachment 164957 [details] [review]
Bug 33407: With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results

With ES and QueryAutoTruncate on, a search with punctuation surrounded
by spaces (like ISBD punctuation copied from other catalogue or
bibliography) returns no results.  E.g.: in a search for "Maria Stuart ;
Die Jungfrau von Orleans / Schiller" (coded in record as 245 10 $a Maria
Stuart ; $b Die Jungfrau von Orleans / $c Schiller) -- both semicolon
and slash cause problems.  One had to remove them manually to get
results which is not what is desired.

Test plan
=========
1. Use ktd with Elasticsearch and ktd's test data
   (http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1):
2. Make a search for the first ISBD zone taken verbatim from the first record:
   E Street shuffle : the glory days of Bruce Springsteen & the E Street Band / Clinton Heylin

   There should be no result.
3. Apply teh patch, restart plack.
4. Repeat the search. You should get the record (and onother one).

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 Roman Dolny 2024-04-16 16:18:44 UTC
Created attachment 164958 [details] [review]
Bug 33407: Unit tests

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>