Bug 33452 - Update patron statistics report
Summary: Update patron statistics report
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy, Sandbox
Depends on:
Blocks: 35806
  Show dependency treegraph
 
Reported: 2023-04-08 19:50 UTC by Katrin Fischer
Modified: 2024-04-18 13:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 33452: Reindent borrowers_stats.tt (30.79 KB, patch)
2024-01-13 21:34 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33452: Update patron statistics search form and result list (10.64 KB, patch)
2024-01-13 21:34 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33452: Improve display of applied filters and results table (11.83 KB, patch)
2024-01-13 21:34 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33452: Reindent borrowers_stats.tt (30.84 KB, patch)
2024-01-25 23:42 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33452: Update patron statistics search form and result list (10.70 KB, patch)
2024-01-25 23:43 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33452: Improve display of applied filters and results table (11.89 KB, patch)
2024-01-25 23:43 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-08 19:50:31 UTC
The patron statistics report is missing the page section on the results table.
Comment 1 Katrin Fischer 2024-01-13 21:34:45 UTC
Created attachment 161021 [details] [review]
Bug 33452: Reindent borrowers_stats.tt

This patch only contains whitespace changes, including
switching from tabs to 4 spaces for indenting
consistently.

To test:
* There shoudl be no change in appearance and behavior
Comment 2 Katrin Fischer 2024-01-13 21:34:47 UTC
Created attachment 161022 [details] [review]
Bug 33452: Update patron statistics search form and result list

This makes changes to terminology, spelling and
capitalization. Terminology used should be the
same as on the normal patron form.

To test:
* Go to Reports > Patrons statistics
* Compare search form before and after patch.
  List of changes:
  * Gender:
    * Add option 'Other'
    * Change men and women to 'Male' and 'Female'
  * Sort*:
    * Labels changed from "Sortx" to "Sort x"
    * Note: to see Sort 1 you need to add an AV for bsort1
 * Patron status:
    * Options changed to start with a capital letter
    * 'Lost' changed to 'Lost card'
 * Patron activity:
    * Options changed to start with a capital letter
    * 'no active' changed to 'Not active'
 * Patron attributes:
    * Switched code and description in label, so description is first
* Do a search, compare result table before and after patch.
  * Added white background (page-section) to results
Comment 3 Katrin Fischer 2024-01-13 21:34:50 UTC
Created attachment 161023 [details] [review]
Bug 33452: Improve display of applied filters and results table

This makes various improvements on the display of the results:

* Filters didn't display the value that was filtered on
* Filter labels were not translatable
* Results table showed line/column using untranslatable codes
* Results table showed library and patron category codes
  instead of descriptions

To test:
* Use the various filters in the form
* Use various combinations of row/column
* Verify it all works as expected and display is much improved

Note:
* In the filters, the code for extended patron attributs will
  be used as label.
* In the results table only patron category codes and library
  codes translate to descriptions.
  Other values from pull downs haven't been implemented yet.
Comment 4 Brendan Lawlor 2024-01-24 20:35:06 UTC
I tested this out and the changes to the form labels and the display of the table look good to me. It's especially nice that the filters display accurately above the results table.

While I was testing and looking at the code I noticed another small improvement could be made to the results table by right aligning the <td> elements that have numerical data. It's easily done by adding class="text-right" in a few places.

Question about Bugzilla testing and submitting patches: would it be ok to add an attachment to this bug with the proposed alignment change? or should I just sign off on this bug and file a new bug for the numerical alignment and attach that change separately?

Thanks!
Comment 5 Katrin Fischer 2024-01-25 21:49:59 UTC
Hi Brendan, thanks for testing! As this already includes a lot of different changes, I think it would make it a little easier to put any additional ones into a separate bug report that is dependent on this one.
Comment 6 Lucas Gass 2024-01-25 23:42:58 UTC
Created attachment 161471 [details] [review]
Bug 33452: Reindent borrowers_stats.tt

This patch only contains whitespace changes, including
switching from tabs to 4 spaces for indenting
consistently.

To test:
* There shoudl be no change in appearance and behavior

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Lucas Gass 2024-01-25 23:43:00 UTC
Created attachment 161472 [details] [review]
Bug 33452: Update patron statistics search form and result list

This makes changes to terminology, spelling and
capitalization. Terminology used should be the
same as on the normal patron form.

To test:
* Go to Reports > Patrons statistics
* Compare search form before and after patch.
  List of changes:
  * Gender:
    * Add option 'Other'
    * Change men and women to 'Male' and 'Female'
  * Sort*:
    * Labels changed from "Sortx" to "Sort x"
    * Note: to see Sort 1 you need to add an AV for bsort1
 * Patron status:
    * Options changed to start with a capital letter
    * 'Lost' changed to 'Lost card'
 * Patron activity:
    * Options changed to start with a capital letter
    * 'no active' changed to 'Not active'
 * Patron attributes:
    * Switched code and description in label, so description is first
* Do a search, compare result table before and after patch.
  * Added white background (page-section) to results

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Lucas Gass 2024-01-25 23:43:02 UTC
Created attachment 161473 [details] [review]
Bug 33452: Improve display of applied filters and results table

This makes various improvements on the display of the results:

* Filters didn't display the value that was filtered on
* Filter labels were not translatable
* Results table showed line/column using untranslatable codes
* Results table showed library and patron category codes
  instead of descriptions

To test:
* Use the various filters in the form
* Use various combinations of row/column
* Verify it all works as expected and display is much improved

Note:
* In the filters, the code for extended patron attributs will
  be used as label.
* In the results table only patron category codes and library
  codes translate to descriptions.
  Other values from pull downs haven't been implemented yet.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>