To recreate: -Set the sys pref 'RecordLocalUseOnReturn' to 'record'. -prove -v /kohadevbox/koha/t/db_dependent/Circulation.t # Subtest: Tests for BlockReturnOfWithdrawnItems 1..1 not ok 1 - Item returned as withdrawn, no other messages # Failed test 'Item returned as withdrawn, no other messages' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 5816. # Structures begin differing at: # $got->[1]{LocalUse} = '1' # $expected->[1]{LocalUse} = Does not exist # Looks like you failed 1 test of 1. not ok 65 - Tests for BlockReturnOfWithdrawnItems # Subtest: Tests for transfer not in transit # Failed test 'Tests for BlockReturnOfWithdrawnItems' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 5819. 1..2 not ok 1 - Item is reported to have been transferred # Failed test 'Item is reported to have been transferred' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 5837. # Structures begin differing at: # $got->[1]{LocalUse} = '1' # $expected->[1]{LocalUse} = Does not exist ok 2 - The datesent field is populated, i.e. transfer is initiated # Looks like you failed 1 test of 2. not ok 66 - Tests for transfer not in transit
Created attachment 152346 [details] [review] Bug 33500: Account for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass.
Created attachment 152347 [details] [review] Bug 33500: Account for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 152352 [details] [review] Bug 33500: Add tests for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass.
Created attachment 152355 [details] [review] Bug 33500: Add tests for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. Signed-off-by: Sam Lau <samalau@gmail.com>
Filled assignee :)
Created attachment 152623 [details] [review] Bug 33500: Add tests for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to 22.11.x for next release