On the 'scan index' page in the staff interface, there is a typo in the template: <option value="su">Series</option> su is the index for subjects. This should be series-title or se.
Created attachment 149576 [details] [review] Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results.
Created attachment 149577 [details] [review] Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results.
Created attachment 149620 [details] [review] Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results. Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. One thing I noted (not related to this bug) is that: - when using Zebra, only 20 results are displayed - it looks to me like the pagination of search results is missing - when using Elasticsearch, there is pagination at the bottom (like the normal staff interface catalog search results) 2. Also not related to this bug, the results pages need the page section added (bug 31757). I'm happy to add the bugs for these if they don't exist already.
(In reply to David Nind from comment #4) > Testing notes (using KTD): > > 1. One thing I noted (not related to this bug) is that: > - when using Zebra, only 20 results are displayed - it looks to me like > the pagination of search results is missing > - when using Elasticsearch, there is pagination at the bottom (like the > normal staff interface catalog search results) > > 2. Also not related to this bug, the results pages need the page section > added (bug 31757). > > I'm happy to add the bugs for these if they don't exist already. Please ignore this comment. I've added it to bug 33505.
Created attachment 150300 [details] [review] Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Backported to 22.05.x for upcoming 22.05.13