With bug 33032 in 22.11.04 we now show "Other holdings" in the staff interface result list, when the alternate holdings field is not present in the record. Before this patch we showed "No items", which is correct in this case.
Created attachment 149575 [details] [review] Bug 33509: Don't show Other holdings when there are no alternate holdings With bug 33509 alternate holdings defined in AlternateHoldingsField are shown in the staff interface result list. This works greatly when there are items or when there is are alternate holdings (the configured field/subfields exist in the record), but not when there are no items and no alternate holdings. To test: * Add 100a to AlternateHoldingsField * Make a search with some records without items Sample data: perl * Make sure the alternate holdings show when there are no items and 100a exists * Change to 100z * Verify the result list now shows "Other holdings:" with nothing below * Apply patch * Repeat * Alternate holdings should still show nicely * Without alternate holdings 'no items' is displayed
Created attachment 149616 [details] [review] Bug 33509: Don't show Other holdings when there are no alternate holdings With bug 33509 alternate holdings defined in AlternateHoldingsField are shown in the staff interface result list. This works greatly when there are items or when there is are alternate holdings (the configured field/subfields exist in the record), but not when there are no items and no alternate holdings. To test: * Add 100a to AlternateHoldingsField * Make a search with some records without items Sample data: perl * Make sure the alternate holdings show when there are no items and 100a exists * Change to 100z * Verify the result list now shows "Other holdings:" with nothing below * Apply patch * Repeat * Alternate holdings should still show nicely * Without alternate holdings 'no items' is displayed Signed-off-by: David Nind <david@davidnind.com>
Created attachment 149639 [details] [review] Bug 33509: Don't show Other holdings when there are no alternate holdings With bug 33509 alternate holdings defined in AlternateHoldingsField are shown in the staff interface result list. This works greatly when there are items or when there is are alternate holdings (the configured field/subfields exist in the record), but not when there are no items and no alternate holdings. To test: * Add 100a to AlternateHoldingsField * Make a search with some records without items Sample data: perl * Make sure the alternate holdings show when there are no items and 100a exists * Change to 100z * Verify the result list now shows "Other holdings:" with nothing below * Apply patch * Repeat * Alternate holdings should still show nicely * Without alternate holdings 'no items' is displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.13
applied to 21.11 for 21.11.21