Bug 33550 - Rename Patron restrictions administration page 'Patron restriction types'
Summary: Rename Patron restrictions administration page 'Patron restriction types'
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Caroline Cyr La Rose
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 23681
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-17 20:17 UTC by Caroline Cyr La Rose
Modified: 2023-12-11 13:47 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact: Philip Orr
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/766
Text to go in the release notes:
Version(s) released in:
23.05.00


Attachments
Bug 33550: Rename Patron restrictions administration page to Patron restriction types (10.79 KB, patch)
2023-04-17 21:00 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33550: Rename Patron restrictions administration page to Patron restriction types (10.85 KB, patch)
2023-04-18 13:31 UTC, Marius
Details | Diff | Splinter Review
Bug 33550: Rename Patron restrictions administration page to Patron restriction types (10.10 KB, patch)
2023-04-25 21:47 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types) (1.17 KB, patch)
2023-04-25 21:47 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33550: Remove period in patron restriction type description (1.10 KB, patch)
2023-04-27 19:20 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33550: Remove question mark in breadcrumb (1.00 KB, patch)
2023-04-27 19:20 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33550: Rename Patron restrictions administration page to Patron restriction types (10.15 KB, patch)
2023-04-27 20:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types) (1.21 KB, patch)
2023-04-27 20:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 33550: Remove period in patron restriction type description (1.15 KB, patch)
2023-04-27 20:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 33550: Remove question mark in breadcrumb (1.05 KB, patch)
2023-04-27 20:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 33550: Rename Patron restrictions administration page to Patron restriction types (10.25 KB, patch)
2023-05-09 21:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types) (1.32 KB, patch)
2023-05-09 21:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33550: Remove period in patron restriction type description (1.26 KB, patch)
2023-05-09 21:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33550: Remove question mark in breadcrumb (1.16 KB, patch)
2023-05-09 21:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33550: (QA follow-up) Switch from double to single quotes in text (1.42 KB, patch)
2023-05-09 21:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-04-17 20:17:30 UTC
This is a suggestion because I think it would make more sense (we have attribute types, credit types, debit types, etc.) but also to help with translations. Right now, the term for a restriction on a specific patron and the term for the restriction type administration are the same, but they don't mean the same thing.

#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt:130
#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:38
#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:57
#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:167
#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:218
#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:1411
#: koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc:58
#, c-format
msgid "Patron restrictions"
msgstr "Restrictions de l'utilisateur"

In memberentrygen, it's to add a restriction to a specific patron
In admin-home/menu and restrictions, it's to add restriction types

Therefore, I think the administration page should be named 'Patron restriction types'.

Opinions?
Comment 1 Caroline Cyr La Rose 2023-04-17 21:00:05 UTC
Created attachment 149780 [details] [review]
Bug 33550: Rename Patron restrictions administration page to Patron restriction types

This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration.

To test:
0. Apply patch
1. Enable PatronRestrictionTypes
2. Go to Administration
3. Check the name, spelling/grammar of the following elements
   * Section name
   * Section caption
4. Click 'Patron restriction types'
5. Check the name, spelling/grammar of the following elements
   * Title of the page (in the browser tab)
   * Breadcrumb
   * Left hand side menu
   * 'New' button
   * Page heading
6. Click 'New restriction type'
7. Check the name, spelling/grammar of the following elements
   * Title of the page (in the browser tab)
   * Breadcrumb
   * Page heading
8. Fill out the form and click 'Save' to create a new restriction type
   * Dialog message ('Restriction type added')
9. Click 'New restriction type'
10. Enter the same code as last time
    * Warning ('Restriction type code is already in use')
11. Click 'Cancel'
12. Click 'Edit' next to one of the types
13. Check the name, spelling/grammar of the following elements
    * Title of the page (in the browser tab)
    * Breadcrumb
    * Page heading
14. Without changing anything, click 'Save'
    * Warning ('Restriction type label is already in use')
15. Change the label and click 'Save'
    * Dialog message ('Restriction type updated')
16. Click 'Delete' next to one of the types
17. Check the name, spelling/grammar of the following elements
    * Title of the page (in the browser tab)
    * Breadcrumb
    * Page heading
    * Delete button
18. Click 'Delete this restriction type'
    * Dialog message ('Restriction type deleted')
Comment 2 Marius 2023-04-18 13:31:39 UTC
Created attachment 149807 [details] [review]
Bug 33550: Rename Patron restrictions administration page to Patron restriction types

This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration.

To test:
0. Apply patch
1. Enable PatronRestrictionTypes
2. Go to Administration
3. Check the name, spelling/grammar of the following elements
   * Section name
   * Section caption
4. Click 'Patron restriction types'
5. Check the name, spelling/grammar of the following elements
   * Title of the page (in the browser tab)
   * Breadcrumb
   * Left hand side menu
   * 'New' button
   * Page heading
6. Click 'New restriction type'
7. Check the name, spelling/grammar of the following elements
   * Title of the page (in the browser tab)
   * Breadcrumb
   * Page heading
8. Fill out the form and click 'Save' to create a new restriction type
   * Dialog message ('Restriction type added')
9. Click 'New restriction type'
10. Enter the same code as last time
    * Warning ('Restriction type code is already in use')
11. Click 'Cancel'
12. Click 'Edit' next to one of the types
13. Check the name, spelling/grammar of the following elements
    * Title of the page (in the browser tab)
    * Breadcrumb
    * Page heading
14. Without changing anything, click 'Save'
    * Warning ('Restriction type label is already in use')
15. Change the label and click 'Save'
    * Dialog message ('Restriction type updated')
16. Click 'Delete' next to one of the types
17. Check the name, spelling/grammar of the following elements
    * Title of the page (in the browser tab)
    * Breadcrumb
    * Page heading
    * Delete button
18. Click 'Delete this restriction type'
    * Dialog message ('Restriction type deleted')

Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com>
Comment 3 Caroline Cyr La Rose 2023-04-19 13:52:13 UTC
Putting this back to Needs signoff since Marius works with me :)
Comment 4 Lucas Gass 2023-04-25 20:28:43 UTC
Unfortunately this patch set no longer applies cleanly to current master.
Comment 5 Caroline Cyr La Rose 2023-04-25 21:47:39 UTC
Created attachment 150229 [details] [review]
Bug 33550: Rename Patron restrictions administration page to Patron restriction types

This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration.

To test:
0. Apply patch
1. Enable PatronRestrictionTypes
2. Go to Administration
3. Check the name, spelling/grammar of the following elements
   * Section name
   * Section caption
4. Click 'Patron restriction types'
5. Check the name, spelling/grammar of the following elements
   * Title of the page (in the browser tab)
   * Breadcrumb
   * Left hand side menu
   * 'New' button
   * Page heading
6. Click 'New restriction type'
7. Check the name, spelling/grammar of the following elements
   * Title of the page (in the browser tab)
   * Breadcrumb
   * Page heading
8. Fill out the form and click 'Save' to create a new restriction type
   * Dialog message ('Restriction type added')
9. Click 'New restriction type'
10. Enter the same code as last time
    * Warning ('Restriction type code is already in use')
11. Click 'Cancel'
12. Click 'Edit' next to one of the types
13. Check the name, spelling/grammar of the following elements
    * Title of the page (in the browser tab)
    * Breadcrumb
    * Page heading
14. Without changing anything, click 'Save'
    * Warning ('Restriction type label is already in use')
15. Change the label and click 'Save'
    * Dialog message ('Restriction type updated')
16. Click 'Delete' next to one of the types
17. Check the name, spelling/grammar of the following elements
    * Title of the page (in the browser tab)
    * Breadcrumb
    * Page heading
    * Delete button
18. Click 'Delete this restriction type'
    * Dialog message ('Restriction type deleted')

Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com>
Comment 6 Caroline Cyr La Rose 2023-04-25 21:47:41 UTC
Created attachment 150230 [details] [review]
Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types)
Comment 7 Caroline Cyr La Rose 2023-04-25 21:48:29 UTC
I tried rebasing. Not sure what I'm doing so crossing my fingers it worked ;)
Comment 8 David Nind 2023-04-26 20:02:04 UTC
Hi Caroline.

Your rebase worked, as I was able to successfully apply the patch!

Some minor things I noted when testing:

1. Administration page: There is a full stop at the end of the description. No other administration menu options on the administration have this.

2. Page title when modifying and deleting a restriction type: in the page title that shows in the browser tab, the <span> tag is visible and has ' either side of it. For example:  Modify restriction type '<span>Test patron restriction type</span>' > 
Patron restriction types > Administration > Koha. Note that this was the case before the patch was applied.

3. Breadcrumb when deleting a restriction type: I'm not sure I've have seen a question mark in breadcrumbs before, except for this one (although I haven't looked very hard). Maybe the breadcrumb should be "Confirm restriction type deletion", to match the page title.

David
Comment 9 Lucas Gass 2023-04-26 22:10:37 UTC
> 2. Page title when modifying and deleting a restriction type: in the page
> title that shows in the browser tab, the <span> tag is visible and has '
> either side of it. For example:  Modify restriction type '<span>Test patron
> restriction type</span>' > 
> Patron restriction types > Administration > Koha. Note that this was the
> case before the patch was applied.

I believe this problem is fixed in Bug 33551.
Comment 10 David Nind 2023-04-26 23:10:05 UTC
(In reply to Lucas Gass from comment #9)
> > 2. Page title when modifying and deleting a restriction type: in the page
> > title that shows in the browser tab, the <span> tag is visible and has '
> > either side of it. For example:  Modify restriction type '<span>Test patron
> > restriction type</span>' > 
> > Patron restriction types > Administration > Koha. Note that this was the
> > case before the patch was applied.
> 
> I believe this problem is fixed in Bug 33551.

Thanks Lucas for identifying that!
Comment 11 Caroline Cyr La Rose 2023-04-27 19:20:15 UTC
Created attachment 150312 [details] [review]
Bug 33550: Remove period in patron restriction type description
Comment 12 Caroline Cyr La Rose 2023-04-27 19:20:17 UTC
Created attachment 150313 [details] [review]
Bug 33550: Remove question mark in breadcrumb
Comment 13 Caroline Cyr La Rose 2023-04-27 19:22:42 UTC
Hi David,

Thanks for you input! I removed the period in the admin section description and changed the breadcrumb of the delete page to "Delete restriction type 'something'" to match the Modify page.

Let me know if it worked!

Caroline
Comment 14 David Nind 2023-04-27 20:22:39 UTC
Created attachment 150316 [details] [review]
Bug 33550: Rename Patron restrictions administration page to Patron restriction types

This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration.

To test:
0. Apply patch
1. Enable PatronRestrictionTypes
2. Go to Administration
3. Check the name, spelling/grammar of the following elements
   * Section name
   * Section caption
4. Click 'Patron restriction types'
5. Check the name, spelling/grammar of the following elements
   * Title of the page (in the browser tab)
   * Breadcrumb
   * Left hand side menu
   * 'New' button
   * Page heading
6. Click 'New restriction type'
7. Check the name, spelling/grammar of the following elements
   * Title of the page (in the browser tab)
   * Breadcrumb
   * Page heading
8. Fill out the form and click 'Save' to create a new restriction type
   * Dialog message ('Restriction type added')
9. Click 'New restriction type'
10. Enter the same code as last time
    * Warning ('Restriction type code is already in use')
11. Click 'Cancel'
12. Click 'Edit' next to one of the types
13. Check the name, spelling/grammar of the following elements
    * Title of the page (in the browser tab)
    * Breadcrumb
    * Page heading
14. Without changing anything, click 'Save'
    * Warning ('Restriction type label is already in use')
15. Change the label and click 'Save'
    * Dialog message ('Restriction type updated')
16. Click 'Delete' next to one of the types
17. Check the name, spelling/grammar of the following elements
    * Title of the page (in the browser tab)
    * Breadcrumb
    * Page heading
    * Delete button
18. Click 'Delete this restriction type'
    * Dialog message ('Restriction type deleted')

Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com>
Signed-off-by: David Nind <david@davidnind.com>
Comment 15 David Nind 2023-04-27 20:22:42 UTC
Created attachment 150317 [details] [review]
Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types)

Signed-off-by: David Nind <david@davidnind.com>
Comment 16 David Nind 2023-04-27 20:22:44 UTC
Created attachment 150318 [details] [review]
Bug 33550: Remove period in patron restriction type description

Signed-off-by: David Nind <david@davidnind.com>
Comment 17 David Nind 2023-04-27 20:22:47 UTC
Created attachment 150319 [details] [review]
Bug 33550: Remove question mark in breadcrumb

Signed-off-by: David Nind <david@davidnind.com>
Comment 18 David Nind 2023-04-27 20:24:26 UTC
(In reply to Caroline Cyr La Rose from comment #13)
> Hi David,
> 
> Thanks for you input! I removed the period in the admin section description
> and changed the breadcrumb of the delete page to "Delete restriction type
> 'something'" to match the Modify page.
> 
> Let me know if it worked!
> 
> Caroline

Thanks Caroline!

It worked 8-)

David
Comment 19 Katrin Fischer 2023-05-09 21:10:40 UTC
Created attachment 150900 [details] [review]
Bug 33550: Rename Patron restrictions administration page to Patron restriction types

This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration.

To test:
0. Apply patch
1. Enable PatronRestrictionTypes
2. Go to Administration
3. Check the name, spelling/grammar of the following elements
   * Section name
   * Section caption
4. Click 'Patron restriction types'
5. Check the name, spelling/grammar of the following elements
   * Title of the page (in the browser tab)
   * Breadcrumb
   * Left hand side menu
   * 'New' button
   * Page heading
6. Click 'New restriction type'
7. Check the name, spelling/grammar of the following elements
   * Title of the page (in the browser tab)
   * Breadcrumb
   * Page heading
8. Fill out the form and click 'Save' to create a new restriction type
   * Dialog message ('Restriction type added')
9. Click 'New restriction type'
10. Enter the same code as last time
    * Warning ('Restriction type code is already in use')
11. Click 'Cancel'
12. Click 'Edit' next to one of the types
13. Check the name, spelling/grammar of the following elements
    * Title of the page (in the browser tab)
    * Breadcrumb
    * Page heading
14. Without changing anything, click 'Save'
    * Warning ('Restriction type label is already in use')
15. Change the label and click 'Save'
    * Dialog message ('Restriction type updated')
16. Click 'Delete' next to one of the types
17. Check the name, spelling/grammar of the following elements
    * Title of the page (in the browser tab)
    * Breadcrumb
    * Page heading
    * Delete button
18. Click 'Delete this restriction type'
    * Dialog message ('Restriction type deleted')

Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=33500
Comment 20 Katrin Fischer 2023-05-09 21:10:43 UTC
Created attachment 150901 [details] [review]
Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=33500
Comment 21 Katrin Fischer 2023-05-09 21:10:46 UTC
Created attachment 150902 [details] [review]
Bug 33550: Remove period in patron restriction type description

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=33500
Comment 22 Katrin Fischer 2023-05-09 21:10:49 UTC
Created attachment 150903 [details] [review]
Bug 33550: Remove question mark in breadcrumb

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=33500
Comment 23 Katrin Fischer 2023-05-09 21:10:52 UTC
Created attachment 150904 [details] [review]
Bug 33550: (QA follow-up) Switch from double to single quotes in text

As we use single quotes in general and also in breadcrumbs and page
title on this specific page, we shoudl also use them for the main
content:

Are you sure you want to delete 'T'?

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=33500
Comment 24 Tomás Cohen Arazi 2023-05-16 18:19:37 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 25 Matt Blenkinsop 2023-06-02 16:19:40 UTC
Enhancement - not backporting to 22.11.x