The new restriction types are not stored anymore and therefore right now, useless :( More so that creates quite an issue for libraries using it as they can no longer differentiate/report etc. properly. To test: * Activate PatronRestrictionTypes * Add a new restriction type from Administration * Open a patron account and add the new restriction by choosing it from the pull down * Save * Review the saved restriction: it says Manual instead of your restriction type. I the database it's also wrong.
Caused by bug 31095
Created attachment 149972 [details] [review] Bug 33574: Correct pointer for restrict_type.code Somehow this was missed during QA of bug 31095.. likely during a rebase. Test plan: 1) Check that manual restriction types are now saved.
Created attachment 149983 [details] [review] Bug 33574: Correct pointer for restrict_type.code Somehow this was missed during QA of bug 31095.. likely during a rebase. Test plan: 1) Check that manual restriction types are now saved. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 23.05. Nice work everyone, thanks!
Lol, I just got to that one! Would be great if it could still make it into 22.11.05 :)
Nice work everyone! Pushed to stable for 22.11.x
Not needed in 22.05.x