Bug 33587 - "Save" button in modifying "News" entry is not working in Russian localization
Summary: "Save" button in modifying "News" entry is not working in Russian localization
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: 22.11
Hardware: PC Windows
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-21 18:57 UTC by Leonid
Modified: 2023-12-28 20:42 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leonid 2023-04-21 18:57:31 UTC
Overview: "Save" button is not working when you click on it while modifying "News" entry when Koha is in Russian localization. Switching to English localization resolves the issue. 

Steps to reproduce:
- Staff interface - Tools - News - Add new entry
- Fill fields
- Click on "Save"("Сохранить") button

Actual result:
Nothing happens, the entry is not saving.

Expected result:
The entry is saving and the user brings to "News" page.

Additional info:
The issue is not reproducing when you fill the quite same page for HTML customizations. On English localization all work as expected.
In intranet-error.log there are some entries about "wide character", maybe it can affect on the issue. These entries also appears on other pages of Koha.
Example:
[Fri Apr 21 18:52:36.183764 2023] [cgi:error] [pid 2183] [client 109.92.248.138:51053] AH01215: Wide character (U+438) in substitution (s///) at /usr/lib/x86_64-linux-gnu/perl5/5.34/Template/Filters.pm line 62.: /usr/share/koha/intranet/cgi-bin/tools/additional-contents.pl, referer: http://45.12.236.250:8080/cgi-bin/koha/tools/additional-contents.pl?op=add_form&category=news&editmode=wysiwyg
Comment 1 Katrin Fischer 2023-04-21 19:40:49 UTC
I have tried to reproduce the issue on the current development branch, but it works as expected there with ru-RU. News entries can be edited and changes are saved correctly.

I think this could be a translation issue, but reviewing the translations for ru-RU nothing stood out. 

If this is a translation issue, it needs to be identified and fixed on translate.koha-community.org. Maybe you can see in your template something that should not have been translated?
Comment 2 Jonathan Druart 2023-05-10 09:16:23 UTC
Confirmed on 22.11.05

Uncaught SyntaxError: missing ) after argument listadditional-contents.pl:1055:59


It's coming from
  alert(_("Укажите название для "По умолчанию""));


You should surround the string with simple quote. Please fix on pootle at translate.koha-community.org/
Comment 3 Katrin Fischer 2023-05-10 10:46:36 UTC
I went ahead and fixed the string on Pootle. The fix will be included in the next maintenance versions.