Bug 33614 - Templates contain problematic references to local login
Summary: Templates contain problematic references to local login
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-26 01:21 UTC by David Cook
Modified: 2023-05-01 23:32 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2023-04-26 01:21:01 UTC
Bug 31064 wrapped the local login fields with a "local-login" class.

However, if you hide the local login fields using this class, there are still references to local login in the SSO implementations where they say things like the following:

--

Sorry, the CAS login also failed. If you have a local login you may use that below.

If you have a local account, you may use that below.

If you do not have a Shibboleth account, but you do have a local login, then you may login below.

If you do not have a Google account, but do have a local account, you can still log in:

--

These references should either include the "local-login" class so they can be hidden, or these references should be removed.
Comment 1 Katrin Fischer 2023-05-01 14:03:39 UTC
I think CSS might not be the correct solution here. You'll still want to have helpful text/notes. 

I feel like we need to adapt the templates for having no local login?

There is OPACShibOnly. Do we need this for OIDC and others too? Or turn it into a general "LocalLogin" switch? 

We have opacuserlogin, but that totally turns off anything that requires or looks like login.
Comment 2 David Cook 2023-05-01 23:32:26 UTC
(In reply to Katrin Fischer from comment #1)
> There is OPACShibOnly. Do we need this for OIDC and others too? Or turn it
> into a general "LocalLogin" switch? 

I like the idea of a general "LocalLogin" switch! 

Or I suppose OpacLocalLogin since we'd be focused on the OPAC in this case.